Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchLogs only works when running SuperviseAll() #24

Open
AdamJSoftware opened this issue Dec 8, 2022 · 2 comments
Open

WatchLogs only works when running SuperviseAll() #24

AdamJSoftware opened this issue Dec 8, 2022 · 2 comments

Comments

@AdamJSoftware
Copy link

I have a weird scenario where I don't want to run SuperviseAll(). Rather I want to dynamically supervise and unsupervise processes depending on requests by just calling ovr.Supervise(). When it comes to WatchState(), this works fine, however I have noticed that WatchLogs only works if I call SuperviseAll. One workaround was to read Cmd.Stdout and cmd.Stderr when adding the process to overseer. However that stops working when the process restarts.

Any ideas?

@croqaz
Copy link
Member

croqaz commented Dec 8, 2022

Indeed it looks like a bug. Supervise alone should make the logs work, SuperviseAll doesn't do anything special about the logs.
I don't think I'll find time to work on this, especially because I'm currently not using this library anywhere.
If you have any ideas or fixes, feel free to leave them here, or make a PR.

@kentlallen
Copy link
Contributor

Changes made to logging in #25 seem to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants