Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier Bonus Ranking #3

Open
Fierydemise opened this issue Dec 5, 2015 · 1 comment
Open

Tier Bonus Ranking #3

Fierydemise opened this issue Dec 5, 2015 · 1 comment

Comments

@Fierydemise
Copy link
Collaborator

In get_other_ep() 4pc bonuses should be compared without other tier 2pc and 4pc bonuses. Similarly 4pc bonuses should be evaluated only with that tier 2pc bonus. Whether to handle 2pc bonuses as 2pc/2pc or just one 2pc bonus should be handled as a flag.

@confusingbits
Copy link
Member

I could work on this next. The problem is that the comparison is done with the currently equipped bonuses?

  1. We wanted to just remove the bonuses for the baseline, and then apply them for the delta?

2 ) And ensure that only matching sets are calculated together for 4p?

  1. And offer a flag to calc the 2/4p effect in a set independently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants