Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jfrog: Update to version 1.44.0 #1821

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Conversation

nixxo
Copy link
Contributor

@nixxo nixxo commented Feb 15, 2021

address issue in #150

Close #1969

Copy link
Contributor

@pratikpc pratikpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change checkver to GitHub?

    "checkver": {
        "github": "https://github.com/jfrog/jfrog-cli"
    },

Using a GitHub checkver is usually more popular with most Scoop projects and usually less prone to breakage.

@nixxo
Copy link
Contributor Author

nixxo commented Feb 19, 2021

I think it's better to check the version in the same repository where the build is available.
On github is only available the source code and not the build package.

I don't know the release schedule of the jfrog project and I don't know if they release the source code and the build at the same time or maybe they release the source code before and the nthe build server creates the release... etc.

So I think it's better to check the version in the same place where you actually download the package because it gives you exactly the latest available package to download.

@CryoTheRenegade
Copy link
Contributor

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

jfrog

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@CryoTheRenegade
Copy link
Contributor

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

jfrog

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

jfrog

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@chawyehsu chawyehsu changed the title jfrog: fix autoupdate url jfrog: Update to version 1.44.0 Apr 2, 2021
@chawyehsu chawyehsu merged commit f761bab into ScoopInstaller:master Apr 2, 2021
@nixxo nixxo deleted the patch-1 branch April 2, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JFrog CLI Frozen at 1.43.2
5 participants