-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jfrog: Update to version 1.44.0 #1821
Conversation
address issue in ScoopInstaller#150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also change checkver to GitHub?
"checkver": {
"github": "https://github.com/jfrog/jfrog-cli"
},
Using a GitHub checkver is usually more popular with most Scoop projects and usually less prone to breakage.
I think it's better to check the version in the same repository where the build is available. I don't know the release schedule of the jfrog project and I don't know if they release the source code and the build at the same time or maybe they release the source code before and the nthe build server creates the release... etc. So I think it's better to check the version in the same place where you actually download the package because it gives you exactly the latest available package to download. |
/verify |
Your changes do not pass checks. jfrog
|
/verify |
All changes look good. Wait for review from human collaborators. jfrog
|
All changes look good. Wait for review from human collaborators. jfrog
|
address issue in #150
Close #1969