New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessors #10

Open

HugoGranstrom opened this issue Jan 22, 2021 · 1 comment

Member

HugoGranstrom commented Jan 22, 2021

Right now there are a few tests in https://github.com/SciNim/flambeau/blob/master/tests/arraymancerTestSuite/tensor/test_accessors.nim that fail. Most notably:

No bounds-checking
Expression like a[1, 1] += 10 isn't possible because a[1, 1] is immutable.

The text was updated successfully, but these errors were encountered:

Member Author

HugoGranstrom commented Jan 23, 2021

Added the slicer test as well: https://github.com/SciNim/flambeau/blob/master/tests/arraymancerTestSuite/tensor/test_accessors_slicer.nim
And there are not many tests that work. Seems like the more advanced slices doesn't work really like _ and ^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment