Revamp working of Batched Solvers #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 92.30% 92.01% -0.30%
==========================================
Files 16 20 +4
Lines 819 952 +133
==========================================
+ Hits 756 876 +120
- Misses 63 76 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
avik-pal
force-pushed
the
ap/batch_revamp
branch
2 times, most recently
from
e912230
to
061ec7d
Compare
This reverts commit e905737.
avik-pal
force-pushed
the
ap/batch_revamp
branch
from
8864cac
to
fe341b2
Compare
avik-pal
force-pushed
the
ap/batch_revamp
branch
from
fe341b2
to
908a98e
Compare
avik-pal
changed the title
|
@ChrisRackauckas, this is ready for review. This is quite an aggressive change to how things work internally, but the speedups seem worth it. The CI failures seem related to SciMLOperators and LinearSolve. |
|
@ChrisRackauckas bump on this |
ChrisRackauckas
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some very crude benchmarks using a problem size of
1 x 1000(i.e., 1000 batch size)Broyden
11.312 ms (883 allocations: 2.27 MiB)10.678 ms (545 allocations: 548.62 KiB)10.915 ms (522 allocations: 373.94 KiB)LBroyden
OLD:Failed ConvergenceNEW:Same Failed ConvergenceNEW (in-place):Same Failed ConvergenceNot updating it since my updates again broke it. For NN cases anyways BatchedDFSane seems to be more reliable and fast.
SimpleDFSane
1.389 ms (1510 allocations: 2.61 MiB)1.093 ms (261 allocations: 1.05 MiB)1.014 ms (242 allocations: 929.45 KiB)Raphson
N/A997.954 ms (6452 allocations: 142.61 MiB)N/ASummary of Updates:
if batchingand similar, I am separating the code for batched and unbatched versions for easier maintenance