Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch didn't propagate problem kwargs #127

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Feb 9, 2024

No description provided.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9e4e49d) 90.13% compared to head (b13c598) 90.22%.

Files Patch % Lines
src/SimpleNonlinearSolve.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   90.13%   90.22%   +0.08%     
==========================================
  Files          20       20              
  Lines        1217     1217              
==========================================
+ Hits         1097     1098       +1     
+ Misses        120      119       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Make a test for this?

@ChrisRackauckas ChrisRackauckas merged commit 4ed9e45 into main Feb 15, 2024
14 of 19 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/propagate_kwargs branch February 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants