Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downgrade CI #110

Merged
merged 11 commits into from
Feb 10, 2024
Merged

Add downgrade CI #110

merged 11 commits into from
Feb 10, 2024

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Dec 25, 2023

Downgrade CI

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c258563) 90.13% compared to head (ddc5fa0) 90.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          20       20           
  Lines        1217     1217           
=======================================
  Hits         1097     1097           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Get tests passing

@ChrisRackauckas
Copy link
Member

Rebase onto master. @avik-pal just fixed the tests.

@ChrisRackauckas
Copy link
Member

Looks like some bound is needed

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Fails due to some allocations

@avik-pal
Copy link
Member

avik-pal commented Feb 9, 2024

Very confused about these failures. Not sure how any of the downstream packages is affecting allocations

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Fixed the downgrade. Can you look at the Bryoden failures? https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/7856403406/job/21439489594?pr=110

@ChrisRackauckas ChrisRackauckas merged commit d0ef3e3 into SciML:main Feb 10, 2024
12 of 16 checks passed
@avik-pal
Copy link
Member

Even the NonlinearSolve Broyden is failing exclusively on Mac. I will try sshing into one of the mac minis to see if I can reproduce this.

@avik-pal
Copy link
Member

Can't reproduce the failure on the macminis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants