-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downgrade CI #110
Add downgrade CI #110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 20 20
Lines 1217 1217
=======================================
Hits 1097 1097
Misses 120 120 ☔ View full report in Codecov by Sentry. |
Get tests passing |
Rebase onto master. @avik-pal just fixed the tests. |
Signed-off-by: ErikQQY <[email protected]>
9b58792
to
1c017bb
Compare
Looks like some bound is needed |
Fails due to some allocations |
Very confused about these failures. Not sure how any of the downstream packages is affecting allocations |
Fixed the downgrade. Can you look at the Bryoden failures? https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/7856403406/job/21439489594?pr=110 |
Even the NonlinearSolve Broyden is failing exclusively on Mac. I will try sshing into one of the mac minis to see if I can reproduce this. |
Can't reproduce the failure on the macminis |
Downgrade CI