Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Baseline Models #825

Open
sibre28 opened this issue Jun 3, 2024 · 1 comment
Open

Improve Baseline Models #825

sibre28 opened this issue Jun 3, 2024 · 1 comment
Assignees
Labels
enhancement 💡 New feature or request performance 🏃 Speed things up

Comments

@sibre28
Copy link
Contributor

sibre28 commented Jun 3, 2024

Is your feature request related to a problem?

Currently the Baseline Functions of #811 take about a minute, with the extended search taking even a lot longer.
We could maybe improve the performance of these models by improving the multiprocessing.

Desired solution

Try out other multiprocessing libraries, this one seems to be promising and could also improve User Feedback, especially with the progress bar:
https://github.com/sybrenjansen/mpire

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@sibre28 sibre28 added enhancement 💡 New feature or request performance 🏃 Speed things up labels Jun 3, 2024
@sibre28 sibre28 self-assigned this Jun 3, 2024
@lars-reimann
Copy link
Member

Generally, I'd rather not add another dependency for this. If there are significant performance gains, however, we can consider it. But we'll need to benchmark it on our own case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request performance 🏃 Speed things up
Projects
Status: Backlog
Development

No branches or pull requests

2 participants