Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failable initializers in EthereumClient and AlchemyClient #19

Open
ronaldmannak opened this issue Jan 18, 2022 · 0 comments
Open

Comments

@ronaldmannak
Copy link
Contributor

Currently, EthereumClient and its subclass AlchemyClient have failable initalizers. The initializers return nil if the URL can't be created from the provided path string parameter. This shouldn't be a runtime error (unless we want the end-user to type in an end point like MetaMask allows, which I think we don't want).

I propose we change the initializers into non-failable initializers for simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant