Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate snews-data-formats into snews_pt #123

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

justinvasel
Copy link
Contributor

@justinvasel justinvasel commented Aug 18, 2024

Note: Requesting testing by other experts to confirm the funcationality still works as expected before merging

Note: This will not be compatible with snews_cs until snews-data-formats is integrated into that project as well.

This is a major PR which will introduce breaking changes in exchange for a simplified message creation and validation process, and decoupling between snews_cs and snews_pt.

Here is a summary of the changes:

  1. Replace legacy message classes and validation logic with snews-data-formats
  2. Some message field names are changed:
  • neutrino_timeneutrino_time_utc
  • machine_timemachine_time_utc
  • sent_timesent_time_utc
  • t_bin_widtht_bin_width_sec
  • retract_latestretract_latest_n
  1. Application code present in __init__.py is moved into __main__.py
  2. Individual message tests are consolidated into a single file
  3. Depcrated patterns are updated (e.g., datetime.utcnow()datetime.now(UTC))
  4. Add pyproject.toml file with pytest configuration
  5. General cleanup and tidying (e.g., rearranging imports, whitespace, etc.
  6. Updated requirements.txt where necessary (including hop-client -> v.0.10.0)
  7. Minimum required Python version bumped from 3.9 to 3.11.

Resolves: #85, #110, #114, #121

@justinvasel justinvasel added the enhancement New feature or request label Aug 20, 2024
@justinvasel justinvasel changed the title WIP - Integrate snews data formats Integrate snews-data-formats into snews_pt Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Tier Message Creation
1 participant