Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing the snews format checker #75

Open
KaraMelih opened this issue Oct 5, 2023 · 2 comments
Open

Replacing the snews format checker #75

KaraMelih opened this issue Oct 5, 2023 · 2 comments
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@KaraMelih
Copy link
Collaborator

With SNEWS2/SNEWS_Publishing_Tools#81 we are getting rid of the snews format checker, and instead validating the messages upon generation.

Previously we were using a script called snews format checker where the neutrino times, p values etc are checked for each message in a standalone script, and using the same script within the snews coincidence system to make sure that the message comes from snews pt and not a stray message injected into the stream -which might potentially crash the server if not ignored.

Now that we have gotten rid of that, we should either write something that checks the similar properties of each received message, or we can again use the snews_pt as a dependency and try to rebuild a new message and check if it self validates again.

I'm open to alternative suggestions.

@KaraMelih KaraMelih added enhancement New feature or request invalid This doesn't seem right labels Oct 5, 2023
@KaraMelih
Copy link
Collaborator Author

@sybenzvi this is the issue I was referring to. @justinvasel suggested to use Pydantic which we also had discussed in the past. It may now be a good time to reconsider it.

@KaraMelih
Copy link
Collaborator Author

to keep an eye on the issue, I mention it here.
Being worked at here; https://github.com/SNEWS2/snews-data-formats
@justinvasel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant