Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CRAN submission #136

Closed
pbulsink opened this issue Jul 21, 2023 · 9 comments
Closed

Finish CRAN submission #136

pbulsink opened this issue Jul 21, 2023 · 9 comments
Milestone

Comments

@pbulsink
Copy link
Collaborator

I think it's ready for CRAN submission!

Close Issues #37, #38, #39, #59, merge PR #134, #135.

Unless you think #78 or #123 are outstanding?

@SCasanova
Copy link
Owner

I do think #123 is important but I think I cracked it yesterday (I want your opinion on my solution)

However as it's not a perfect solution I do think it could remain as a part of the "dev" version post-CRAN

@SCasanova
Copy link
Owner

Other than that I think we're ready to submit

@pbulsink
Copy link
Collaborator Author

I do think #123 is important but I think I cracked it yesterday (I want your opinion on my solution)

However as it's not a perfect solution I do think it could remain as a part of the "dev" version post-CRAN

Gladly! If you put a PR I can likely fetch from that dev branch.

@SCasanova
Copy link
Owner

Sorry, I've been very busy. Will push later today

@SCasanova SCasanova added this to the CRAN Release milestone Jul 23, 2023
@SCasanova
Copy link
Owner

On second thought, I think it needs more work. We should go ahead without it for now.

@pbulsink
Copy link
Collaborator Author

pbulsink commented Jul 24, 2023 via email

@SCasanova
Copy link
Owner

Sounds good. Should I get the submission going then?

@pbulsink
Copy link
Collaborator Author

pbulsink commented Jul 24, 2023 via email

@SCasanova
Copy link
Owner

Will submit it then! I opened a checklist based on https://r-pkgs.org/release.html. So therefore I will now close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants