Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog]: Change combobox selection will crash app #9957

Open
1 task done
skowrons opened this issue Sep 28, 2024 · 3 comments
Open
1 task done

[Dialog]: Change combobox selection will crash app #9957

skowrons opened this issue Sep 28, 2024 · 3 comments
Labels
bug This issue is a bug in the code TOPIC Core

Comments

@skowrons
Copy link

Describe the bug

When we use a ComboBox inside a Dialog component it will crash the app after we change the selection again.

Isolated Example

https://stackblitz.com/edit/github-fzbkcn?file=src%2FApp.tsx

Reproduction steps

  1. Open Dialog
  2. Select something without search
  3. Select some other thing
  4. App will crash

Expected Behaviour

App should not crash.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.1.1

UI5 Web Components Version

2.2.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@skowrons skowrons added the bug This issue is a bug in the code label Sep 28, 2024
@skowrons
Copy link
Author

This error will not surface on Safari.

Screenshot: Bildschirmfoto 2024-09-28 um 15 51 09

Chrome Version: Version 129.0.6668.71 (Offizieller Build) (x86_64) (newest currently)

@Lukas742
Copy link
Collaborator

Lukas742 commented Sep 30, 2024

Hi @skowrons

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi Colleagues,

with plain HTML and JS, I wasn't able to reproduce the exact same error, but still an error is thrown when dynamically adding ComboBoxItems in runtime. So, it probably has the same root cause.

Edit: I've used the wrong tag-name for the ComboBoxItems. I've edited my example and now the app crashes with plain HTML and JS as well.

Example: https://stackblitz.com/edit/github-994pyy-pic3za?file=index.html,main.js,package.json

  1. Open Dialog
  2. Select something without search
  3. Select some other thing
  4. App will crash

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Sep 30, 2024
@LidiyaGeorgieva
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-core,

Please advice what could be the issue here?

I tested the following:

  • on Firefox there is no crash, only on Chrome (I tested with Windows)
  • I tried to isolate it with minimal code in the test page (of the Dialog for example) and its reproducible also there:
<ui5-dialog id="dialogForm" header-text="Dialog">
		<ui5-form>
			<ui5-form-item>
			  <ui5-combobox placeholder="Enter value">
				<ui5-cb-item text="Austria"></ui5-cb-item>
				<ui5-cb-item text="Bulgaria"></ui5-cb-item>
				<ui5-cb-item text="Germany"></ui5-cb-item>
			</ui5-combobox>
			</ui5-form-item>
		  </ui5-form>
	</ui5-dialog>
  • if I delete the ui5-dialog or the ui5-form - the issue is not reproducible. Only this combination of components cause the crash

Best Regards,
Lidiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC Core
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants