Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Okay score range for DependencyScanScore data provider #862

Open
ManjunathMS35 opened this issue Aug 17, 2022 · 0 comments
Open

Fix Okay score range for DependencyScanScore data provider #862

ManjunathMS35 opened this issue Aug 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ManjunathMS35
Copy link
Contributor

After the introduction of Snyk score, the DependencyScanScore "okay" range lies in the "very good" range, which can be confirmed from the test vector here

fosstars-rating-core/src/test/resources/com/sap/oss/phosphor/fosstars/model/score/oss/DependencyScanScoreTestVectors.yml

Line 106 in 02f66d6

# okay project

Issue cause: Having GitHub as development environment sub score feature in both Dependabot score and Snyk score might have increased the DependencyScanScore okay range.

Things to do:

  1. Fix the oaky rating range for DependencyScanScore
@ManjunathMS35 ManjunathMS35 added the bug Something isn't working label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ManjunathMS35