-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better error handling and display elegant error messages #5
Comments
Hey @RyanRussell00, |
@sonamdh1 If you look at this page on the Spotify docs it explains all the API's responses. I'm not quite sure how we should be displaying errors. Currently, if the user inputs an invalid input on a required field it just highlights it in red and shows an error message. Not very intuitive. As for the API errors, right now, if there's an API error there's a regular alert box that comes up with very generic (and not helpful) messages. Maybe we could change this to a better looking modal and add some more meaningful messages? There is no exact specification as to how the error handling should look/work, as long as it's intuitive and looks better than what we have now. Let me know if you have any more questions |
@RyanRussell00 Ah alright, totally missed the error messages displayed after invalid input. I think that is fine, I have seen form validation errors like that on various web pages. Though the message can be displayed on the right-hand side along the input field. I think displaying a combined error message might not make it easier to navigate for the errored input fields. Thanks for sharing the API documentation, will try to add some specific messages for handling different status codes. Also, in place of the default alert, will add a custom modal. Can you please share some instances in which the API for recommendations and save-playlist are giving error, that will make it easier for me to generate the scenarios and make the changes? |
@sonamdh1 Sorry for the late reply. Some instance when the API gives an error:
That's all I can think of off the top of my head. You should also add a generic error handler in case we get other responses for whatever reason (such as Spotify server being down, or some other weird issue). Let me know if you have any more questions, thanks! |
@RyanRussell00 Sorry, I started working on it, but due to some reasons, I'm not able to get time to work on it and probably won't be able to take it up again in the coming month as well. |
@sonamdh1 No problem, thanks for letting me know! This issue is open for anyone to work on |
There are times when the user is unable to add a playlist (see #4). This is mostly because the app isn't letting the user know what the error is, whether it be on their side or on the API side.
Add better error handling so that users are informed of what failed and why it failed.
The text was updated successfully, but these errors were encountered: