-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin crashes when child compiler has errors #53
Comments
Thanks for the report. Can you please provide a simple reproduce case for this scenario? |
meskill
added a commit
to meskill/webpack-build-notifier
that referenced
this issue
Jun 20, 2020
@RoccoC |
RoccoC
added a commit
that referenced
this issue
Jun 23, 2020
RoccoC
added a commit
that referenced
this issue
Jun 23, 2020
* Upgraded all depepndencies to latest * Updated CI script. * Configured travis for node@10. * Added warning/error handling for child compiler instances (#53). * Updated version
@meskill , this has been fixed in Thanks for the bug report and reproduce case -- do let me know if you run into any issues with the latest release. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some other plugins can create child compilers (for example extract-css-chunks-webpack-plugin) which will lead to a crash with errors like this
if that child compiler has errors or warnings
This is happening due to the code inside webpack.Stats.hasErrors which checks errors also inside child compilers.
To fix the issue we need to extract errors and warnings also from child compilers if there are no errors in the current one.
The text was updated successfully, but these errors were encountered: