-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications not showing up on Windows 10 #43
Comments
Hi @david-hollifield , thanks for the report! I'm seeing the same thing after upgrading to Windows 10 1903 as well. I will investigate, but may be something that needs to be addressed in |
Hi @RoccoC, PS. I changed the wait to true on my local version and it now shows the notification |
Hi @quintonn, good question. Setting I suppose we could temporarily set wait to true on Windows machines until the root cause is fixed? Alternatively, we could allow the consumer to override the wait option via config? Thoughts? |
Hi @RoccoC, I didn't realize it prevents a build until the notification is dismissed. |
This fix might fix bug 45 also? |
@quintonn , just tested out your PR, thanks. In my testing it seems that while the notification is now shown consistently in Windows (due to setting |
@quintonn, I think I've come up with a fix. Would you mind testing using the Note that in the case of error notifications, the build will always be blocked until the notification is dismissed, however. You can target the branch version by updating the dependency in your project's
Let me know how it goes, thanks! |
I've tested this change but i don't see notifications now. And also wait is set to !buildstatus again, which is false. If i set wait to true, i see the notification but build doesn't complete. But i am wondering if all of this is worth it, The fix should be in node-notifier. |
If i put the setTimeout back on the notifier.notify call and with webpack watch, if i make a change, save it, it shows the notification, and without closing the notification, if i make another change and save it, it shows another notification. I think the issue might be related to the fact that Node only uses 1 thread, so the setTimeout only moves that call to be the last call being executed, so it will always wait for the notification to be dismissed if we set wait to true. |
Which version of webpack is your project using? |
"webpack": "^4.39.2", I see there is a bit newer version. will try that one |
On new version it showed the notification on the first build without waiting for the notification to be dismissed, perfect. Using webpack watch also does not show the notification anymore. Ps. i'm going on holiday today, so won't be able to help with this for a while |
Maybe updating to the latest node-notifier (with latest SnoreToast) will resolve this issue. |
👀 |
I've updated to |
@RoccoC Works great! Thank you! |
Great, thanks for verifying! |
I'm not sure what's happened, but notifications have stopped working again :(. |
@david-hollifield -- apologies for the delay in my response. I will have a look this morning. |
After an update to Windows 10 1903, notifications stopped popping up. They do show up as notifications in the notification area after a reboot. Any ideas?
The text was updated successfully, but these errors were encountered: