Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add async version of the API calls #55

Open
rue-vmom opened this issue Apr 22, 2020 · 0 comments
Open

Please add async version of the API calls #55

rue-vmom opened this issue Apr 22, 2020 · 0 comments

Comments

@rue-vmom
Copy link

For example:

sdk_net/Riskified.SDK/Orders/OrdersGateway.cs

Line 141 in f9b3c95

public OrderNotification Decide(Order order)

There should be an async version of this that returns a Task.

See https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/async/ for the reasoning behind this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rue-vmom