Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support token cards #96

Open
Marcus-Smallman opened this issue Aug 28, 2022 · 2 comments
Open

Support token cards #96

Marcus-Smallman opened this issue Aug 28, 2022 · 2 comments

Comments

@Marcus-Smallman
Copy link

Marcus-Smallman commented Aug 28, 2022

There are various cards with the card code ending in T1 T2 (e.g. 04PZ001T4) etc..

The method public static string GetCodeFromDeck(List<CardCodeAndCount> deck) now fails if you provide it with a card codes that contains T1 etc..

@ed-flanagan
Copy link
Contributor

OOC: are there any token cards you can add to a deck? I was under the impression they were auxiliary cards used for "regular" cards' effects and such.

@Marcus-Smallman
Copy link
Author

OOC: are there any token cards you can add to a deck? I was under the impression they were auxiliary cards used for "regular" cards' effects and such.

During Path of Champions I was able to buy and add the card 04PZ001T4 to my deck. I understand that they are not "regular" cards, but it would be good to be able to get the deckcode for a deck that contains them and it not error.

It would also be really good if the /static-decklist endpoint returned the correct deckcode all the time as well.
I am currently using the the cards returned from the endpoint, and then the GetCodeFromDeck method to retrieve the deck code as I found that it didn't always return a deck code. If this was resolved I wouldn't need to use the GetCodeFromDeck method at all, but that's probably a separate issue and it would still probably be good for the library to support token cards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants