Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trashed download still appears in Downloads screen #179

Open
jcraigk opened this issue Sep 5, 2019 · 2 comments
Open

Trashed download still appears in Downloads screen #179

jcraigk opened this issue Sep 5, 2019 · 2 comments

Comments

@jcraigk
Copy link

jcraigk commented Sep 5, 2019

I have a show whose content I downloaded and then trashed, but it still appears in the Downloads page.

I am not sure how to reliably reproduce this issue but I think I did the following:
(1) Navigated to show (GD 1971-11-07)
(2) Select a source (3 of 5 - Peter Kafer)
(3) Download the tracks
(4) Go to Downloads screen
(5) Select the show, select the downloaded source
(6) Tap on delete icon
(7) The show still appears in Downloads

At this point the app may have crashed or I may have manually crashed it to fix another issue, but now when I go to Downloads page I still see GD 1971-11-07 and there is a downloaded indicator on the source, but when I select that, there is no downloaded indicator and no delete button on the actual Show screen itself, as if it was not downloaded. So it is not clear if it's really deleted or not.

EDIT: in order to correct it, I had to download the complete show again and then trash it. If I downloaded only a few tracks and trashed them, the show still appeared. I suspect this means that the delete action initially only deleted a few tracks OR only a few tracks were downloaded when I clicked on the trash icon. Either way there is a state issue that needs to be fixed here.

@farktronix
Copy link
Member

I'm not able to reproduce this, so this is either fixed in the latest beta or it's some kind of race condition in the download manager where the show got stuck looking like it was downloaded.

@farktronix
Copy link
Member

I managed to get this to reproduce. This happens if you download more than one source for a show- Relisten doesn't show the sources list, and it just jumps back to the deleted source which doesn't show as downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants