Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Jenkins Pipeline hard-codes the config groovy files #95

Open
jeichler opened this issue Oct 12, 2017 · 3 comments
Open

Jenkins Pipeline hard-codes the config groovy files #95

jeichler opened this issue Oct 12, 2017 · 3 comments

Comments

@jeichler
Copy link
Collaborator

currently:

def loadEnvVars() {
  loadEnvVarsFromFile("script-env-vars.groovy")
  if (params.PUPPET_ONLY == true) {
    loadEnvVarsFromFile("script-env-vars-puppet-only.groovy")
  } else {
    loadEnvVarsFromFile("script-env-vars-rpm.groovy")
  }
}

if you want to use the Jenkinsfile for example with el6 and el7, you need to use another branch or copy it. that's far from good.

PR is coming this week to resolve this.

@jeichler
Copy link
Collaborator Author

jeichler commented Nov 3, 2017

for the reviewers, I hope that you especially check the documentation, maybe even you could check it @ericzolf since you pointd out some missing or unclear things.

for testing it might be worth to create 2 jobs, one which pulls, one which executes the pipeline - following the documentation should lead to a successfully running build.

@jeichler
Copy link
Collaborator Author

jeichler commented Nov 6, 2017

@ericzolf it has been merged, so it should be sufficient for you to test the jenkins_pipeline branch and/or read the https://github.com/RedHatSatellite/soe-ci/blob/jenkins_pipeline/README.md

@pcfe
Copy link
Collaborator

pcfe commented Jul 11, 2018

this has been working fine for many months in RedHatSatellite:jenkins_pipeline
@ericzolf @nstrug is there anything that speaks against finally enabling pipelines and deprecating the old non-pipeline way?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants