Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grammar breaks extension #2

Open
harrydowning opened this issue Sep 8, 2024 · 4 comments
Open

New grammar breaks extension #2

harrydowning opened this issue Sep 8, 2024 · 4 comments

Comments

@harrydowning
Copy link

VS Code version

Version: 1.93.0
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
Date: 2024-09-04T13:02:38.431Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.5.0

The new VS Code YAML grammar breaks the yaml-embedded-languages extension. I'm not sure why as installing your extension directly makes it work again. Do you know what could be the problem.

@RedCMD
Copy link
Owner

RedCMD commented Sep 9, 2024

VSCode is still using an outdated version of the grammar
71a8871 has the fix already

I was under the impression the changes had already gone through
but it seems I missed the pull update by a few hours microsoft/vscode#224954

I doubt they will fix it in the next Recovery release

if you don't want to wait for the next full release
you could patch yours by consuming the whitespace before the block-scalar ([ \t]*)([|>])...
or temporary force my extension along with yours: package.json

"extensionDependencies": [
	"redcmd.yaml-syntax"
]

@harrydowning
Copy link
Author

Do you know how long it will be until the next release?

@RedCMD
Copy link
Owner

RedCMD commented Sep 9, 2024

First week of October I presume

microsoft/vscode#228053

@harrydowning
Copy link
Author

Looks like it has been added to the August recovery https://github.com/microsoft/vscode/milestone/281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants