Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"await" is missing #13027

Open
muxa-xoma opened this issue Mar 24, 2024 · 2 comments
Open

"await" is missing #13027

muxa-xoma opened this issue Mar 24, 2024 · 2 comments

Comments

@muxa-xoma
Copy link

sio.enter_room(sid, data["session_id"])

Missing "await" before sio.enter_room(sid, data[“session_id”])

@yousole
Copy link

yousole commented Mar 25, 2024

When session_persistence is set to true, SocketIO cannot reply properly.
sio.enter_room(sid, data["session_id"]) needs to be changed to await sio.enter_room(sid, data["session_id"]).

@ThePythonDev
Copy link

As mentioned before issues are now all on Jira:
https://rasa-open-source.atlassian.net/jira/software/c/projects/OSS/issues?jql=project%20%3D%20%22OSS%22%20ORDER%20BY%20created%20DESC
So I would suggest heading over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants