Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of rules in character sets is underspecified #846

Open
codesections opened this issue Oct 18, 2023 · 1 comment
Open

Behavior of rules in character sets is underspecified #846

codesections opened this issue Oct 18, 2023 · 1 comment

Comments

@codesections
Copy link
Contributor

Roast has many tests where a rule is combined into a character set. For example, S05-metasyntax/charset.t. However, all of the current tests use a rule that can match against a single character. This means that the behavior of a token that requires multiple characters is unspecified.

I believe that the correct behavior is, to quote jnthn from a different issue:

<+foo> if foo matches more than one char [means that]: it has to match, but we only advance the cursor by 1 position however much it matches.

Unless anyone disagrees with this behavior, it should be specced, probably in S05-metasyntax/charset.t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant