Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify and remove dead CSS selectors; promote common style definitions to this gem #24

Open
armahillo opened this issue Apr 5, 2021 · 0 comments
Open

Identify and remove dead CSS selectors; promote common style definitions to this gem #24

armahillo opened this issue Apr 5, 2021 · 0 comments

Comments

@armahillo
Copy link
Contributor

#flash_messages > #error_explanation is quite likely unused anywhere (#error_explanation seems to be a child of form instead)

There are probably other CSS selectors that aren't being used as well. We can clean this cruft out to simplify the styles.

We can also promote style definitions that are common to all the apps to this gem's theme styles. (among others, flash hash, form errors, etc).

This is related to #22 and #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@armahillo