Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalizing jones matrix for Nfeeds=1,2 #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

slosar
Copy link
Contributor

@slosar slosar commented Mar 30, 2022

Changes the jones matrix routine to (Nfeeds,2) instead of (2,2) generalizing to any Nfeeds. Down the line Nfeeds can still be only 1 or 2, but this can be changed. This is only a proposal.

Description

See file changes - pretty obvious. Still specialized for theta-phi coordinate system.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #394 (c28cf25) into main (8092079) will decrease coverage by 0.04%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   99.34%   99.29%   -0.05%     
==========================================
  Files          13       13              
  Lines        2126     2130       +4     
==========================================
+ Hits         2112     2115       +3     
- Misses         14       15       +1     
Impacted Files Coverage Δ
pyuvsim/uvsim.py 99.15% <83.33%> (-0.28%) ⬇️
pyuvsim/antenna.py 96.07% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8092079...c28cf25. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant