Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruff for linting (replaces flake8, black and isort) #255

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

bhazelton
Copy link
Member

Switch to using the ruff formatter to solve several issues:

  • Speed
  • Versioning Flake8 plugins
  • configuration via pyproject.toml rather than .flake8

Description

Fixes #250

Motivation and Context

Checklists:

Build/CI Change Checklist:

  • I have read the contribution guide.
  • My code follows the code style of this project.
  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme

@bhazelton bhazelton added technical debt Code cleanup to meet our own standards packaging continuous integration labels Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5d4b950) to head (398ac10).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2131      2121   -10     
  Branches       608       601    -7     
=========================================
- Hits          2131      2121   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

steven-murray
steven-murray previously approved these changes Jul 21, 2024
Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, but with the one comment that the pyproject.toml can be slightly cleaner by using inline comments

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, I have one comment but I think it is more about uniformity across rasg repos.

pyproject.toml Show resolved Hide resolved
@mkolopanis mkolopanis merged commit 3447fa0 into main Jul 22, 2024
34 checks passed
@mkolopanis mkolopanis deleted the ruff_linter branch July 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration packaging technical debt Code cleanup to meet our own standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving to Ruff from flake8
3 participants