Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden file download function #4

Open
jasonnance opened this issue Sep 6, 2019 · 0 comments
Open

Harden file download function #4

jasonnance opened this issue Sep 6, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jasonnance
Copy link
Collaborator

Feature

Implement some functionality to make downloading and caching files more robust.

Motivation

There are some potential pitfalls related to filename collisions, partial downloads, and bookkeeping with the current implementation.

Additional Details

  • Hash each URL, store the actual file under that directory (to prevent issues when files have the same name from different URLs)
  • Store metadata file with the downloaded file to indicate when it was downloaded successfully
  • Save to temp file and rename to the final file after download is completely to avoid partially downloaded files
  • Maybe attempt downloads multiple times in the case of flaky connections
@jasonnance jasonnance added the enhancement New feature or request label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant