Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync requirements.in with requirements.txt, and update dependencies #293

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

andykawabata
Copy link
Contributor

Sync requirements.in with requirements.txt

  • it appeared that requirements.txt had been updated independently of requirements.in
  • To reconcile this I unpinned some outdated versions requirements.in and removed the corresponding entries in requirements.txt then re-ran pip-compile

Update Pillow and Sentence-Tranformer

  • Added Pillow to requirements.in which was compiled to a secure version (10.2.0)
  • The above changes allowed sentence-tranformer to compile to a secure version (2.2.0)

Note about pip-compile instructions in README: The readme specifies running the command docker-compose run --rm backend pip-compile docker/requirements.in to compile the requirements. However this method kept giving me a connection error. To run pip-compile i had to open a terminal in the backend container and run it. Wondering if this is just a me problem, or if we should update the README to include this.

Copy link
Contributor

@AstridKery AstridKery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it looks good to me

@AstridKery AstridKery merged commit c7f6ef1 into dev Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants