Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectControl does not use max_missing_heartbeats from conf #619

Closed
Angeleon opened this issue Dec 18, 2023 · 1 comment
Closed

ObjectControl does not use max_missing_heartbeats from conf #619

Angeleon opened this issue Dec 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Angeleon
Copy link
Contributor

Describe the bug
ObjectControl uses iso22133 default MONR_EXPECTED_FREQUENCY_HZ for communication instead of using max_missing_heartbeats and sending this value in the OSEM [Communication Timeout] value.

Expected behavior
If max_missing_heartbeats is set in the params.yaml file, it should overwrite the timeout values in the ObjectControl class and send this timeout in the OSEM message to the test objects.

Branch or release information (please complete the following information):

  • all
@Angeleon Angeleon added the bug Something isn't working label Dec 18, 2023
@Robert108
Copy link
Collaborator

Fixed in #621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Angeleon @Robert108