Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Fedora GRUB as well as (or instead of) upstream GRUB for pvgrub2-pvh #9471

Open
DemiMarie opened this issue Sep 23, 2024 · 9 comments
Open
Labels
C: Fedora P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed.

Comments

@DemiMarie
Copy link

How to file a helpful issue

The problem you're addressing (if any)

Fedora used Boot Loader Spec (BLS). Qubes OS must use deprecated tools to ensure that the dom0-provided GRUB works with Fedora guests.

The solution you'd like

Use Fedora’s fork of GRUB, which should work fine.

The value to a user, and who that user might be

Easier use of in-VM kernels and less maintenance burden for the Qubes team.

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

@DemiMarie DemiMarie added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Sep 23, 2024
@marmarek
Copy link
Member

marmarek commented Sep 23, 2024

<rant> The whole issue wouldn't exist, if Fedora would (at least try to) upstream their changes, instead of using a "standard" that in fact is very Fedora-specific mechanism.</rant>

@DemiMarie
Copy link
Author

<rant> The whole issue wouldn't exist, if Fedora would (at least try to) upstream their changes, instead of using a "standard" that in fact is very Fedora-specific mechanism.</rant>

Per @Conan-Kudo several other distributions use Fedora’s patches.

@Conan-Kudo
Copy link

<rant> The whole issue wouldn't exist, if Fedora would (at least try to) upstream their changes, instead of using a "standard" that in fact is very Fedora-specific mechanism.</rant>

Don't complain to Fedora, complain that the maintainers don't have time to actually process patch submissions for GRUB because their time is taken away doing their jobs (which aren't GRUB).

@DemiMarie
Copy link
Author

<rant> The whole issue wouldn't exist, if Fedora would (at least try to) upstream their changes, instead of using a "standard" that in fact is very Fedora-specific mechanism.</rant>

Don't complain to Fedora, complain that the maintainers don't have time to actually process patch submissions for GRUB because their time is taken away doing their jobs (which aren't GRUB).

I didn’t see any BLS patches on the GRUB mailing list.

@Conan-Kudo
Copy link

Conan-Kudo commented Sep 24, 2024

My understanding is it never got far enough as a lot of the patches to prep for it didn't get reviewed in the far past. But we can ask @nfrayer and @lsandov1 (the new maintainers of GRUB in Fedora) to make a new push for upstreaming.

@lsandov1
Copy link

@Conan-Kudo @DemiMarie and team, I am working on categorizing and preparing patch series to be sent to upstream. I started this task recently but hopefully soon some (those distro-agnostic) patches will land into the grub-devel ML.

@marmarek
Copy link
Member

I am working on categorizing and preparing patch series to be sent to upstream. I started this task recently but hopefully soon some (those distro-agnostic) patches will land into the grub-devel ML.

Thank you!

@andrewdavidwong andrewdavidwong added the waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed. label Sep 24, 2024
@DemiMarie
Copy link
Author

Is this actually waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed. ? The RFE is to offer a GRUB with Fedora’s downstream patches, which isn’t blocked on any upstream as the patches are all available in Fedora’s SRPM. If the plan is to instead wait for the patches to be accepted upstream, this would be R: declined Resolution: While a legitimate bug or proposal, it has been decided that no action will be taken. .

@andrewdavidwong
Copy link
Member

andrewdavidwong commented Sep 27, 2024

@DemiMarie: Not sure. That was just my best guess at the most appropriate classification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Fedora P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed.
Projects
None yet
Development

No branches or pull requests

5 participants