Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not seeing a caps lock warning before entering XScreenSaver password with Caps Lock enabled #9132

Closed
emanruse opened this issue Apr 20, 2024 · 7 comments
Labels
C: desktop-linux-xfce4 Support for XFCE4 diagnosed Technical diagnosis has been performed (see issue comments). P: minor Priority: minor. The lowest priority, below "default." R: upstream issue Resolution: This issue pertains to software that the Qubes OS Project does not develop or control. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@emanruse
Copy link

The problem you're addressing (if any)

The screen unlocker dialog of XFCE provides no visual feedback about Caps Lock being pressed.

The solution you'd like

Provide CapsLock visual clue for XFCE screen unlocker.

The value to a user, and who that user might be

Less failed screen unlock attempts.

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

@emanruse emanruse added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Apr 20, 2024
@andrewdavidwong andrewdavidwong added C: desktop-linux-xfce4 Support for XFCE4 ux User experience labels Apr 20, 2024
@deeplow
Copy link

deeplow commented Sep 26, 2024

By screen unlocker, are you referring to lightDM or xscreensaver?

LightDM xscreensaver
qubes-os-installation-13-1024x556-976267831 85a5db20b084e0c33388ec515417be0dc524ca9a-678057683 (couldn't find an exact 4.2 image match)

If we're talking about LightDM, I believe there is alread a caps lock indication and XScreenSaver does show Caps Lock? if you type your password wrong and have caps enabled. In any case, I think these are issues to be addressed with the particular lock screen / screensaver and not something that can be addressed directly in Qubes (CC @andrewdavidwong).

@emanruse
Copy link
Author

emanruse commented Sep 26, 2024 via email

@andrewdavidwong
Copy link
Member

andrewdavidwong commented Sep 27, 2024

If we're talking about LightDM, I believe there is alread a caps lock indication and XScreenSaver does show Caps Lock? if you type your password wrong and have caps enabled.

Can confirm. I see it every time I try to enter my password with Caps Lock enabled.

I don't see anything like that.

Try this:

  1. Lock your screen and enable Caps Lock (order shouldn't matter).
  2. Type some random text in the password field.
  3. Press Enter.

You should see the Caps Lock? message.

If you still don't: Have you modified your XScreenSaver in some way? What are your Qubes OS and XScreenSaver versions?

@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. and removed T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience labels Sep 27, 2024
@andrewdavidwong andrewdavidwong changed the title Provide CapsLock visual clue for XFCE screen unlocker Not getting the Caps Lock? message when entering XScreenSaver password with Caps Lock enabled Sep 27, 2024
@andrewdavidwong andrewdavidwong added P: minor Priority: minor. The lowest priority, below "default." and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Sep 27, 2024
@emanruse
Copy link
Author

emanruse commented Sep 27, 2024 via email

@alimirjamali
Copy link

My expectation is to have the "Caps Lock?" while typing, not after pressing Enter. This would prevent authentication error rather than inform about it post-factum.

This is something within the hands of the original XscreenSaver upstream developer (Jamie Zawinski). Qubes OS specific patches to it are limited to logos and minor changes. A grave change such as this might break it entirely (in its future updates which might include important security patches).

@emanruse
Copy link
Author

emanruse commented Sep 27, 2024 via email

@andrewdavidwong andrewdavidwong added R: upstream issue Resolution: This issue pertains to software that the Qubes OS Project does not develop or control. diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 28, 2024
Copy link

This issue has been closed as an "upstream issue." This means that the issue pertains to software that does not belong to the Qubes OS Project and that we do not develop or control. We suggest that you file this issue in the appropriate project's issue tracker instead. For more information, see Why don't you fix upstream bugs that affect Qubes OS?

We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community.

If anyone reading this believes that this issue was closed in error or that the resolution of "upstream issue" is not accurate, please leave a comment below saying so, and we will review this issue again. For more information, see How issues get closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
@andrewdavidwong andrewdavidwong changed the title Not getting the Caps Lock? message when entering XScreenSaver password with Caps Lock enabled Not seeing a caps lock warning before entering XScreenSaver password with Caps Lock enabled Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: desktop-linux-xfce4 Support for XFCE4 diagnosed Technical diagnosis has been performed (see issue comments). P: minor Priority: minor. The lowest priority, below "default." R: upstream issue Resolution: This issue pertains to software that the Qubes OS Project does not develop or control. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

4 participants