Incorrect message when renaming of qube fails

[verygreen]

Qubes OS release

4.1.2

Brief summary

When renaming a qube (e.g. template) failes because there's disp vm running, a message is printed that outlines the failure.
This message lists the qube name three times where clearly one of those occurrences is supposed to list the new desired name.

Steps to reproduce

Tename a template that has a dispvm running

[verygreen]

The somewhat trivial fix is here:
QubesOS/qubes-manager#349

though I guess it does not like my lack of signature?

[andrewdavidwong]

though I guess it does not like my lack of signature?

Would you mind generating a key and using it to sign your code? Instructions are provided here:

https://www.qubes-os.org/doc/code-signing/

[verygreen]

I signed the commit, but it's still unhappy.

[andrewdavidwong]

I signed the commit, but it's still unhappy.

Hmm, did you upload your key to one of the approved keyservers?

[verygreen]

there are references to "A key server", in that code signing document, but no instructions how to do it or what those servers are.

[andrewdavidwong]

It's in this section:

https://www.qubes-os.org/doc/code-signing/#upload-the-key

[verygreen]

sorry, somehow missed it. Should be all good now.

[verygreen]

ha, "Great,", now it failed CI seemingly due to unrelated failure to fetch some fedora updates or some such. is there a way to retrigger the test?

[DemiMarie]

Don’t worry @verygreen, it isn’t your fault 😄. I just issued a command that will cause all the failed runs to be retried.

[andrewdavidwong]

QubesOS/qubes-manager#349 was merged a long time ago, but it says that it fixes #8056, not this issue.

Should this issue still be open?

[marmarta]

This should have been closed.