feature: add pyjanitor card #6
Open
+77
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chendaniely
force-pushed
the
package-pyjanitor
branch
2 times, most recently
from
6a9c10a
to
d94dcb2
Compare
Carreau
force-pushed
the
package-pyjanitor
branch
from
d94dcb2
to
27a6cd1
Compare
Apparently, my VSCode settings also formats `data.yaml` to get rid of stray whitespace. My apologies for the bigger diff. We can revert that change if need be.
|
@chendaniely and @Carreau thank you for helping with making this PR! I now feel much less FOMO from SciPy 😄. @chendaniely I created a codespace for the PR, but I don't think I can push to your fork. Could you grant me the necessary permissions please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericmjl we would love your blessing to have
pyjanitoras a card!Since people are confusing the 2 of us anyway, we can pretend you made it here at scipy2022 :D
(we do miss you)
I just got this started for you (Eric) but it would be great if you bless + and change what you want so you actually make it into the commit history :D
pyjanitorlogoPreview of the card (maybe eric can generate and push the png after edits?)