Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch protection for "Execute Notebooks" and "API Checks" #1970

Open
Eric-Arellano opened this issue Sep 17, 2024 · 0 comments
Open

Add branch protection for "Execute Notebooks" and "API Checks" #1970

Eric-Arellano opened this issue Sep 17, 2024 · 0 comments

Comments

@Eric-Arellano
Copy link
Collaborator

It's currrently possible to merge on red. This is particularly dangerous because the button to "merge when ready" will merge even if "API Checks" and "Execute Notebooks" are red. This is because we didn't set up those CI checks in branch protection due to issues with how we skip those jobs - when skipped, it would block the PR from merging since it never runs.

To fix, implement https://www.pantsbuild.org/blog/2022/10/10/skipping-github-actions-jobs-without-breaking-branch-protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant