Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderers panel modification proposal #330

Open
jvanasco opened this issue May 7, 2018 · 2 comments
Open

renderers panel modification proposal #330

jvanasco opened this issue May 7, 2018 · 2 comments

Comments

@jvanasco
Copy link
Contributor

jvanasco commented May 7, 2018

We use a custom exception view to catch certain API errors, and return a formatted json document.

When running with the debugtoolbar enabled, the client is served the correct document from the exception view... however the traceback panel for the squashed exception only contains everything up until that exception is raised.

We can get that info from the renderers panel, but it's a bit awkward as the information is all over the place.

I've got things solved in a custom panel for now, but I'd like to propose either changing the renderers panel or adding a new "response" panel.

In the current "renderer" panel, the "System Values" section is alphabetical. I propose duplicating view and context to their own sections (like render name) above the table.

@stevepiercy
Copy link
Member

Suggest adding a screenshot of your custom panel to illustrate your proposal, if possible. I'm having a hard time visualizing this proposed change.

@jvanasco
Copy link
Contributor Author

jvanasco commented May 7, 2018

Below are the existing and suggested versions (i deleted the query strings from the request, as they had some local test API credentials)

The idea is to just highlight the View/Context info as that is the most useful information available from the 'system' info.

The other stuff is useful too. but it's largely available elsewhere or used for debugging the rendering action as they're the local vars. This is the only panel that says "we ultimately rendered this view".

For background...

  • The request and matched_route points to a view "manage_settings"
  • A permission check failed within the view, raising an ApiPermissionsError, which ultimately raised a ViewException_Permissions_JsonAPI error, which is used to trigger a view of...
  • The view exception_view__Permissions_JsonAPI is called to render a JSON doc.

existing

suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants