Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Google Books API does not return large image for all books #11

Open
bbelderbos opened this issue Sep 29, 2020 · 5 comments
Open

Comments

@bbelderbos
Copy link
Collaborator

For example: http://pbreadinglist.herokuapp.com/books/k1gzDwAAQBAJ
Image link: http://books.google.com/books?id=k1gzDwAAQBAJ&printsec=frontcover&img=1&zoom=2&source=gbs_gdata

I played a bit with it but did not find a consistent / reliable way to always get a big image for a book using Google Books API (= what we use for this project), nor other book APIs.

@karlangadas
Copy link

#16
Hi! I've made a pr with a solution for this bug. Hope it helps.

@bbelderbos
Copy link
Collaborator Author

Thanks @karlangadas, awesome you took this up.
I will test it out locally. What happens if a smaller image gets stored, will it impact the book's page design?

@karlangadas
Copy link

In that case the image will be centered. You can see how it looks like with this book: NQzBJwAACAAJ.

image

On the other hand, I couldn't test it on the slack view. Let me know if there is something to fix on the design for this view. I could get the slack api in order to solve it.

@bbelderbos
Copy link
Collaborator Author

@karlangadas that is neat! I will try it later on my end and merge it in. Thanks

@bbelderbos
Copy link
Collaborator Author

bbelderbos commented Oct 17, 2020

@karlangadas if you have time could you check why some books are not resizing please? http://pbreadinglist.herokuapp.com/books/EzBqBgAAQBAJ (others examples: gVcATKTpirEC and __CvAFrcWY0C)
Thanks!

@bbelderbos bbelderbos reopened this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants