Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Faster Copper oxidizing by splash/lingering Thick Potion #47

Open
2 tasks done
znopp opened this issue Mar 5, 2023 · 2 comments
Open
2 tasks done
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@znopp
Copy link

znopp commented Mar 5, 2023

The idea/problem for your feature request.

Currently it is time consuming and very boring to oxidize copper as it is simply a waiting game. However, by introducing the ability to throw splash/lingering Thick potions on or nearby the Copper blocks would allow them to quickly oxidize.

This would also give a use to the Thick potion.

Describe the solution you'd like.

It should make the nearby copper blocks advance to the next stage of oxidization when splashed with a Thick potion, or in a cloud of Lingering Thick Potion.

Describe alternatives you've considered.

I have tried a datapack, and it works flawlessly on Vanilla, but thanks to Paper it is rather broken. Hopefully an update from the author is coming.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported PurpurExtras version.

Anything Else?

No response

@znopp znopp changed the title Faster Copper oxidizing by splash/lingering Thick Potion [Feature Request] Faster Copper oxidizing by splash/lingering Thick Potion Mar 5, 2023
@YouHaveTrouble
Copy link
Member

After further research I found that it will sadly be not possible to do this, since it would conflict with most anticheats.
My idea is as follows:

  • getting all blocks in range of the potion using location from PotionSplashEvent and raycasting to each of them.
  • each block that is successfully hit by the ray would have to have block break or block place event fired, which would probably trigger most anticheats
  • get step further in the oxidization of the block. this would probably take a few maps or it could just swap the first part of the block id.

This solution would trigger false positives anticheats. If anyone comes up with something better that respects all the claim plugins, I'll happily merge it

@YouHaveTrouble YouHaveTrouble added enhancement New feature or request help wanted Extra attention is needed labels Mar 24, 2023
@TheRealRyGuy
Copy link
Contributor

I mean realistically claim plugins could just disable it - and it can just change block type and disregard events.
Most anti cheats won't flag just off of that small a change (if they're decent), so I'm not sure how much do a concern this would be.
Only way I see this is favor claims plugin vs favor anti cheat plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants