Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database schema to use the userid field instead of username #176

Open
hadiahmed098 opened this issue Sep 27, 2022 · 0 comments
Open
Labels
code enhancement Improvements to the code without noticeably changing user experience
Milestone

Comments

@hadiahmed098
Copy link
Member

Using a username field as the foreign key to link the tables together is not good practice. It is better to use the unique increasing integer that already exists as the primary key in the Users table. This won't change anything for the end user, except we must evaluate the user endpoints to see if they should use the username or userid as the route parameter.

@hadiahmed098 hadiahmed098 added the code enhancement Improvements to the code without noticeably changing user experience label Sep 27, 2022
@hadiahmed098 hadiahmed098 added this to the v2.4+ milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code enhancement Improvements to the code without noticeably changing user experience
Projects
None yet
Development

No branches or pull requests

1 participant