Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent about the type used to represent the base64-encoded cryptographic values involved in the PrivacyPass protocol #279

Open
exarkun opened this issue Jan 8, 2022 · 0 comments
Open

Be consistent about the type used to represent the base64-encoded cryptographic values involved in the PrivacyPass protocol #279

exarkun opened this issue Jan 8, 2022 · 0 comments

Comments

@exarkun
Copy link
Collaborator

exarkun commented Jan 8, 2022

In #263 we converted several model classes to use bytes for their internal representation of PrivacyPass-related values. We still have some other classes which use unicode as their internal representation of similar values - for example, DummyRedeemer._public_key and PaymentController.allowed_public_keys.

It would be good to have a representation for these kinds of values that is consistent across the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@exarkun