Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3837 add rake tasks to run every module only #3843

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stbnrivas
Copy link
Contributor

@stbnrivas stbnrivas commented Apr 24, 2021

Closes #3837

✌️ What does this PR do?

add new rake task to run test by every gobierto module

🔍 How should this be manually tested?

bin/rails -T # should show new task like:

bin/rails test:gobierto_admin
...

@ferblape
Copy link
Member

What's pending here?

@stbnrivas
Copy link
Contributor Author

I am not sure about:

  • namespace location...
  • use the full name of module example: gobierto_admin
  • if I will better use a gem like Open3 instead of puts

@ferblape
Copy link
Member

  • namespace location...

Yes, use a new file (test.rake?). Let's have a single namespace per file

  • use the full name of module example: gobierto_admin

But you are already using the whole module name, right?

  • if I will better use a gem like Open3 instead of puts

The experience would be better if the output is shown instantly so Open3 might help, but don't lose too much time

@stbnrivas stbnrivas force-pushed the 3837-add-tasks-to-segment-tests-by-module branch from 95ef4ae to 4ccd3b1 Compare April 27, 2021 20:01
@stbnrivas stbnrivas marked this pull request as ready for review April 27, 2021 20:01
@stbnrivas
Copy link
Contributor Author

stbnrivas commented Apr 27, 2021

ok, I changed :

  • move to lib/test.rake
  • the command to output
  • add --fail-fast as params to task with
bin/rails test:gobierto_plans[true]

I will include Open3 next time

@stbnrivas stbnrivas changed the title add rake tasks to run every module only 3837 add rake tasks to run every module only Jun 7, 2021
@stbnrivas stbnrivas force-pushed the 3837-add-tasks-to-segment-tests-by-module branch from 7b9a88d to 5d071e0 Compare June 7, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test run by module as rake task
2 participants