Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace precomputed rates in HDF5 file with those from CHIANTI via fiasco #45

Open
wtbarnes opened this issue Apr 27, 2021 · 0 comments
Labels

Comments

@wtbarnes
Copy link

wtbarnes commented Apr 27, 2021

The recombination rates are currently stored in a (version-controlled) HDF5 file. If it is more ideal to not have to maintain this relatively large chunk of data, I will note that fiasco, while still in early development, can calculate relatively easily the ionization and recombination rates as a function of temperature from CHIANTI, e.g. https://fiasco.readthedocs.io/en/latest/generated/gallery/plot_recomb_rate.html.

In can also calculate the equilibrium populations as a function of temperature which is likely useful for constructing a set of initial conditions, e.g. https://fiasco.readthedocs.io/en/latest/generated/gallery/plot_ioneq.html#sphx-glr-generated-gallery-plot-ioneq-py. It looks like this is already done here though:

def _get_equilibrium_charge_states(ioniz_rate, recomb_rate, natom):
It might be worth comparing these two approaches

I realize that having a dependence on an unreleased package is not ideal. I would be happy to push to cut a release of fiasco if having this dependence/capability is something people want.

There is probably also some work to do to reconcile the different ways fiasco and plasmapy treat ions/particles.

@github-actions github-actions bot added the Stale label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant