Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the eigenvalue method time advance #31

Open
namurphy opened this issue Jun 3, 2020 · 2 comments
Open

Optimize the eigenvalue method time advance #31

namurphy opened this issue Jun 3, 2020 · 2 comments
Labels

Comments

@namurphy
Copy link
Member

namurphy commented Jun 3, 2020

Some possibilities include:

  • Doing operations directly on numpy.ndarray objects rather than astropy.units.Quantity objects, since doing stuff with units can slow things down.

Additionally, it would be helpful to have the NEI time advance put into a separate function that deals directly with numpy.ndarray objects. That function could then be decorated with the appropriate Numba decorator, or alternatively implemented in Cython.

@StanczakDominik
Copy link
Member

One of these solutions contains fewer packaging problems. ;)

@namurphy
Copy link
Member Author

The solve involves creation of a diagonal matrix, which is currently done by creating a full matrix of the appropriate size with numpy.zeros and then setting the diagonal elements to the appropriate values. We could probably make use of functionality within scipy.sparse to represent and perform operations with diagonal matrices more efficiently.

@github-actions github-actions bot added the Stale label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants