-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable warnings as errors for weekly run in test suite #6217
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a bunch of suggestions. I would also suggest adding a pull_request
trigger to the workflow once it's reasonably complete so you can test it out in action before the PR gets merged.
…lane into tests/warning_as_error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6217 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.02%
==========================================
Files 444 443 -1
Lines 42321 42230 -91
==========================================
- Hits 42149 42053 -96
- Misses 172 177 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Rashid N H M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of more changes to tidy up the workflow, but functionally looks great!
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We have an epic for next quarter with stories for updating workflows. I'll add a story there to implement the suggestions in this PR that are not able to be done right now.
Note: splitting seems to be affected in this PR. Follow-up re-eval needed. |
Maybe the splits need to be set up in the |
…lane into tests/warning_as_error
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR enables a weekly run of the test suite with Python-level warnings promoted to errors (exceptions). This will allow the test suite to regularly report when hitting warnings through general execution.
Description of the Change: Add a new workflow to run the test suite with Python warnings as errors on a weekly basis,
Benefits: Enable us to catch warnings when and where they occur during testing.
Possible Drawbacks: Additional overhead of running the CI at the intended occurrence.
Related GitHub Issues: