From 669b7f7efaee50b5b00a067bd024282c2ef8e206 Mon Sep 17 00:00:00 2001 From: Thomas David Baker Date: Fri, 13 Sep 2024 12:43:30 -0700 Subject: [PATCH 1/5] Workaround issues with github projects and modo-bugs --- modo_bugs/update.py | 2 ++ modo_bugs/verification.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/modo_bugs/update.py b/modo_bugs/update.py index f871af7ba..b86fb6756 100644 --- a/modo_bugs/update.py +++ b/modo_bugs/update.py @@ -68,6 +68,8 @@ def main() -> None: def verification_numbers() -> None: print('Populating Verification Model') + print('Skipping this because GitHub projects does not work like this any more :(') + return project = repo.get_verification_project() for col in project.get_columns(): if col.name == 'Needs Testing': diff --git a/modo_bugs/verification.py b/modo_bugs/verification.py index 9db660d11..3e2b0a6a7 100644 --- a/modo_bugs/verification.py +++ b/modo_bugs/verification.py @@ -7,6 +7,8 @@ def main() -> None: + print('Verification is currently disabled because GitHub projects does not support this any more') + return manifest = requests.get('http://mtgo.patch.daybreakgames.com/patch/mtg/live/client/MTGO.application') tree = etree.fromstring(manifest.content) identity = tree.find('{urn:schemas-microsoft-com:asm.v1}assemblyIdentity') From b8108fbf6778c6e9aea1ea96ec4dea41fe5ae259 Mon Sep 17 00:00:00 2001 From: Thomas David Baker Date: Fri, 13 Sep 2024 12:43:43 -0700 Subject: [PATCH 2/5] Avoid warning from test runs by providing required param --- pytest.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/pytest.ini b/pytest.ini index 0fa3deb68..a5dbae18a 100644 --- a/pytest.ini +++ b/pytest.ini @@ -1,4 +1,5 @@ [pytest] +asyncio_default_fixture_loop_scope = function addopts = -l -ra --durations=2 --cov=./ --cov-report= --junitxml=TestResults.xml markers = functional: functional tests From e63515d26cdd0acedf982dc2adaa1a1c9c1c96ac Mon Sep 17 00:00:00 2001 From: Thomas David Baker Date: Fri, 13 Sep 2024 12:44:19 -0700 Subject: [PATCH 3/5] A little bit more output when we skip a bug during collection --- modo_bugs/scrape_forum.py | 1 + 1 file changed, 1 insertion(+) diff --git a/modo_bugs/scrape_forum.py b/modo_bugs/scrape_forum.py index 993c7df5a..a8de09716 100644 --- a/modo_bugs/scrape_forum.py +++ b/modo_bugs/scrape_forum.py @@ -36,6 +36,7 @@ def main() -> None: bad.append(url) for url in bad: + print(f'Rejecting {url}') del known[url] with open('forums.json', 'w') as fp: From 9cdf2cbc1cb94e0ced9468b9ad167e1ecee6aedb Mon Sep 17 00:00:00 2001 From: Thomas David Baker Date: Fri, 13 Sep 2024 12:47:05 -0700 Subject: [PATCH 4/5] A little utility to find places we can improve bug tracking --- modo_bugs/untracked.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 modo_bugs/untracked.py diff --git a/modo_bugs/untracked.py b/modo_bugs/untracked.py new file mode 100644 index 000000000..818cb505e --- /dev/null +++ b/modo_bugs/untracked.py @@ -0,0 +1,24 @@ +from shared import fetch_tools + + +def main() -> None: + their_bugs = fetch_tools.fetch_json('https://raw.githubusercontent.com/PennyDreadfulMTG/modo-bugs/master/forums.json') + their_untracked_bugs = [bug for bug in their_bugs.values() if not bug['tracked'] and bug['status'] not in ['Fixed', 'Not A Bug', 'No Fix Planned', 'Could Not Reproduce']] + our_bugs = fetch_tools.fetch_json('https://raw.githubusercontent.com/PennyDreadfulMTG/modo-bugs/master/bugs.json') + our_untracked_bugs = [bug for bug in our_bugs if not bug['support_thread']] + print("= Possible missing linkage:\n") + for our_bug in our_untracked_bugs: + for their_bug in their_untracked_bugs: + if our_bug['card'] in their_bug['title']: + print("Maybe\n", our_bug['description'], "\nis tracked by them as\n", their_bug['title']) + print(their_bug['url']) + print(our_bug['url'] + "\n") + print("= All of their bugs we aren't tracking:\n") + for their_bug in their_untracked_bugs: + print(f'[{their_bug["status"]}] {their_bug["title"]}\n{their_bug["url"]}\n') + print("= All of our bugs they aren't tracking:\n") + for our_bug in our_bugs: + print(f'[{our_bug["card"]}] {our_bug["description"]}\n{our_bug["url"]}\n') + +if __name__ == '__main__': + main() From e5f444951daf316202295c3fc9f9e71d06fafdad Mon Sep 17 00:00:00 2001 From: Thomas David Baker Date: Fri, 13 Sep 2024 12:47:05 -0700 Subject: [PATCH 5/5] A little utility to find places we can improve bug tracking --- modo_bugs/untracked.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modo_bugs/untracked.py b/modo_bugs/untracked.py index 818cb505e..e9e2aecf2 100644 --- a/modo_bugs/untracked.py +++ b/modo_bugs/untracked.py @@ -6,13 +6,13 @@ def main() -> None: their_untracked_bugs = [bug for bug in their_bugs.values() if not bug['tracked'] and bug['status'] not in ['Fixed', 'Not A Bug', 'No Fix Planned', 'Could Not Reproduce']] our_bugs = fetch_tools.fetch_json('https://raw.githubusercontent.com/PennyDreadfulMTG/modo-bugs/master/bugs.json') our_untracked_bugs = [bug for bug in our_bugs if not bug['support_thread']] - print("= Possible missing linkage:\n") + print('= Possible missing linkage:\n') for our_bug in our_untracked_bugs: for their_bug in their_untracked_bugs: if our_bug['card'] in their_bug['title']: - print("Maybe\n", our_bug['description'], "\nis tracked by them as\n", their_bug['title']) + print('Maybe\n', our_bug['description'], '\nis tracked by them as\n', their_bug['title']) print(their_bug['url']) - print(our_bug['url'] + "\n") + print(our_bug['url'] + '\n') print("= All of their bugs we aren't tracking:\n") for their_bug in their_untracked_bugs: print(f'[{their_bug["status"]}] {their_bug["title"]}\n{their_bug["url"]}\n') @@ -20,5 +20,6 @@ def main() -> None: for our_bug in our_bugs: print(f'[{our_bug["card"]}] {our_bug["description"]}\n{our_bug["url"]}\n') + if __name__ == '__main__': main()