Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Optimize CI Pipeline Code #3195

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Conversation

allgandalf
Copy link
Collaborator

@allgandalf allgandalf commented Jul 11, 2023

Description

Referencing to the issue #3194, this PR aims to reduce the code duplication by setting the check command variables as Matrix variables.

Motivation and Context

After the first CI optimization PR, there was a little discussion by @infotroph that we cloud use matrix variables to reduce the code duplication which occurs in the current code.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR resolves #3194

@allgandalf allgandalf changed the title feat: Optimize CI Pipeline Code build: Optimize CI Pipeline Code Jul 11, 2023
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@infotroph
Copy link
Member

I think the "expected" tests are ones that are removed in this PR -- I believe a repo admin will need to go into GitHub's branch protection settings and remove those from the list of required tests.

@allgandalf
Copy link
Collaborator Author

yes, this was done with my last PR for the CI workflow as well 😁, feeling a little guilty over here 😅

@infotroph
Copy link
Member

@mdietze I vote we merge this before any futher changes to CI versions (e.g. #3234) , so that we don't have to change numbers in as many places.

@allgandalf
Copy link
Collaborator Author

With this PR, we also need to disable the Required checks for check_base (4.1) , check_models (4.1) , check_modules (4.1) as they are renamed in this PR, repo admin should be able to do this .

@infotroph infotroph added this pull request to the merge queue Dec 1, 2023
Merged via the queue into PecanProject:develop with commit 7894a8b Dec 1, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further reduce code duplication by setting the check command as a matrix variable
2 participants