Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change chrome driver directory #10

Open
3 tasks
tunglinn opened this issue Jun 12, 2023 · 0 comments
Open
3 tasks

Change chrome driver directory #10

tunglinn opened this issue Jun 12, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers size: small 1-3 hours of work

Comments

@tunglinn
Copy link
Collaborator

Overview

The get_html() function in scraper_functions.py holds a personal directory. We need to change it to the repository and also change the instructions in README.md for installing the Chrome Driver.

Action Items

  • Change default parameter value for driver_path in get_html()
  • Add driver as a .gitignore entry
  • Change instructions in README.md

Resources
@tunglinn tunglinn added documentation Improvements or additions to documentation good first issue Good for newcomers size: small 1-3 hours of work labels Jun 12, 2023
@abhay8298 abhay8298 mentioned this issue Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers size: small 1-3 hours of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10 driver path update
1 participant
@tunglinn