From 3f10019ee27c2cbb44dfbc4bf40eeab2fa38e9f0 Mon Sep 17 00:00:00 2001 From: Wasiq-Ali Date: Mon, 11 Sep 2023 13:22:25 +0500 Subject: [PATCH 1/2] chore(Report_Utils): add a conditon on columns_with_container --- frappe/public/js/frappe/views/reports/report_utils.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/views/reports/report_utils.js b/frappe/public/js/frappe/views/reports/report_utils.js index 8c0d3a38fdb..be22c886828 100644 --- a/frappe/public/js/frappe/views/reports/report_utils.js +++ b/frappe/public/js/frappe/views/reports/report_utils.js @@ -197,6 +197,8 @@ frappe.report_utils = { return `
${items.join("")}
`; }); - return `
${columns_with_container.join("")}
`; + if (columns_with_container.length) { + return `
${columns_with_container.join("")}

`; + } } }; From 7cc9329033f5bb465b5f9051020b2df0e548800b Mon Sep 17 00:00:00 2001 From: Wasiq-Ali Date: Mon, 11 Sep 2023 16:06:43 +0500 Subject: [PATCH 2/2] chore(report_utils): remove condition on columns_with_container --- frappe/public/js/frappe/views/reports/report_utils.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/report_utils.js b/frappe/public/js/frappe/views/reports/report_utils.js index be22c886828..5531eebba66 100644 --- a/frappe/public/js/frappe/views/reports/report_utils.js +++ b/frappe/public/js/frappe/views/reports/report_utils.js @@ -197,8 +197,6 @@ frappe.report_utils = { return `
${items.join("")}
`; }); - if (columns_with_container.length) { - return `
${columns_with_container.join("")}

`; - } + return columns_with_container.length ? `
${columns_with_container.join("")}
` : ""; } };