Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace_view signature does not match that of scenic gem #14

Open
emolayi opened this issue Mar 12, 2019 · 1 comment
Open

replace_view signature does not match that of scenic gem #14

emolayi opened this issue Mar 12, 2019 · 1 comment

Comments

@emolayi
Copy link

emolayi commented Mar 12, 2019

https://github.com/scenic-views/scenic/blob/master/lib/scenic/statements.rb#L135

No sql_definition param is accepted.
@mattalat
Copy link

I think that function wraps the adapter's replace_view method.

The baked-in PG adapter has a signature similar to this Gem's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emolayi @mattalat