{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":50740659,"defaultBranch":"master","name":"PIVX","ownerLogin":"PIVX-Project","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2016-01-30T19:20:24.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16931849?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708463971.0","currentOid":""},"activityList":{"items":[{"before":"3d60bb5cd2bea96ce275acc22d2fba759e59fd53","after":"b5076838fd6e6a3f42d8038e4f39ae0169d21d6a","ref":"refs/heads/master","pushedAt":"2024-08-20T04:04:12.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2934: [GA] Resolve latest macos-14 runner build failures\n\nb944d78a8afddb64a18b1cd650bf15a9ea761e57 [GA] Update apt cache prior to package installation (Fuzzbawls)\n81505c98e61d9a2bdc6e77b14a03de885cccf9e2 [GA] Pin XCode version for macos-14 runners (Fuzzbawls)\nb90f2e8e0b55e1ec8baf17f59fcf0359e9625f6a [Build] Remove unused macOS framework libraries. (Fuzzbawls)\n\nPull request description:\n\n  GA updated the version of XCode used for their macos-14 runners to a version that has known compatibility issues. For now, we can get around this by pinning the XCode version the runner's environment uses.\n\n  Semi-related: included a commit to remove un-used macOS framework libs (ref: https://github.com/bitcoin/bitcoin/pull/20496)\n\n  And lastly, while finalizing this PR, GA's apt cache decided to go out of sync, so now force an apt update prior to package installation.\n\nACKs for top commit: b944d78a8afddb64a18b1cd650bf15a9ea761e57\n  panleone:\n    utACK b944d78a8afddb64a18b1cd650bf15a9ea761e57\n  Liquid369:\n    tACK b944d78a8afddb64a18b1cd650bf15a9ea761e57\n\nTree-SHA512: 07335c067dc56bf1e7d259dfe18dddbba2ae6bc3752ead5a3cb1f95e89d464b3d77653c33d3fc63f7dc6645e32df8982071b673d51a953006b45fd42ec14b9f3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2457560687\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2934\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2934/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2934\">#2934</a>: [GA] Resolve latest macos-14 runner build failures"}},{"before":"4c17603f6c39a18f3f6c971b51af152d4a077662","after":"3d60bb5cd2bea96ce275acc22d2fba759e59fd53","ref":"refs/heads/master","pushedAt":"2024-08-16T22:25:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2887: [Wallet] Some sapling wallet improvements\n\n74f7f94c75dac0564c4f3c6db8d97ac9ce2b6126 Don't generate shield addressed that have already been used (Alessandro Rezzi)\n5efedea6b9e8a9e5b00694cca8aee721b91cd67f Filter Sapling data only when the right flag is set (Alessandro Rezzi)\n\nPull request description:\n\n  first commit: filter sapling credit/debit only when the appropriate flag has been set in the filter\n  second commit: in the qt wallet don't generate shield addresses that have already been used\n\nACKs for top commit: 74f7f94c75dac0564c4f3c6db8d97ac9ce2b6126\n  Fuzzbawls:\n    utACK 74f7f94c75dac0564c4f3c6db8d97ac9ce2b6126\n  Liquid369:\n    tACK 74f7f94c75dac0564c4f3c6db8d97ac9ce2b6126\n\nTree-SHA512: 6f75ee1c35f693d7ecf8872bc470876550961cc7108b56ee09b745adf6c595bd2271aff5efe5274eabdef10f17774327d0041f678a8d3cccffc897a421fe43e0","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1898967816\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2887\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2887/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2887\">#2887</a>: [Wallet] Some sapling wallet improvements"}},{"before":"a254b29762fa4af849a5fc1867b0eb1cad7071da","after":"4c17603f6c39a18f3f6c971b51af152d4a077662","ref":"refs/heads/master","pushedAt":"2024-08-09T09:38:11.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2921: Dash llmq backports\n\n22efef0a526334cde6a29f01bedc3c33b0edc827 No matter how fast we process sig shares, always force 100ms between sending (Alexander Block)\n1bd0c2f76742e4cc16956d01167263609d93f991 Don't sleep in WorkThreadMain when CPU intensive work was done (Alexander Block)\n40a247d4a2f58d7c4cac4be228b86b8283be59ef Implement caching in CRecoveredSigsDb (Alexander Block)\n6c63a776724ac9c6a18be16646cf883a8d2bf2e6 Use CBLSLazySignature in CBatchedSigShares (Alexander Block)\nbff6e6ee5e69a6acb3aa3ab6f97a4cb9b5b9c71c CLLMQUtils::IsQuorumActive() shouldn't require cs_main to be held (UdjinM6)\nfdba615ec308faa3682c5b2328341a40ec881c66 Introduce startBlockHeight to make things more explicit (Alexander Block)\n7bca9a243919d91dc8f0e03acaccb3875630879e Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height (Alexander Block)\n04b6a67c413b96ac8be1da735c91d3b71431af57 Reserve 4k of buffer for CSerializedNetMsg buffer (Alexander Block)\nbe1c4a7350422dfb89d038a60959665e455b91f2 Fix cleanup of old recovered sigs (Alexander Block)\n\nPull request description:\n\n  Backport dash PRs (in the following order):\n  dashpay#2640\n  dashpay#2672\n  dashpay#2674\n  dashpay#2702\n  dashpay#2705\n  dashpay#2706\n  dashpay#2707\n\n  NB: Some or them are partial backports since most of our llmq files are already updated to a more recent upstream version. So I basically ended up picking the commits that touch only the files `quorums_signing_shares.*` and `quorums_signing.*`\n\n  I suggest to review by checking each individual commit against the corresponding upstream one\n\nACKs for top commit: 22efef0a526334cde6a29f01bedc3c33b0edc827\n  Liquid369:\n    tACK 22efef0a526334cde6a29f01bedc3c33b0edc827\n  Duddino:\n    ACK 22efef0a526334cde6a29f01bedc3c33b0edc827\n\nTree-SHA512: 94e5dcdef044524ad4fa4d1fadbe670d839a08ccadc39071ba9300cfc44ce3d19ba24dfef1a6c6745271139d43f43ea47ed5a29e06f0d94e13ff09957f8e0c10","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2226168225\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2921\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2921/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2921\">#2921</a>: Dash llmq backports"}},{"before":"f855a9a948b0a8570aa237a646a239f93b1faea9","after":"a254b29762fa4af849a5fc1867b0eb1cad7071da","ref":"refs/heads/master","pushedAt":"2024-08-03T07:00:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2932: [Bug] Exit early for budget submission when the wallet is locked\n\n67e632bd604588162d44a25cd593f51bc9f24f70 [Bug] Exit early for budget submission when the wallet is locked (Fuzzbawls)\n\nPull request description:\n\n  When the wallet is configured for budget submission, an issue arises where the keypool gets exhausted when the wallet is locked, causing a crash. This prevents such behavior.\n\nACKs for top commit: 67e632bd604588162d44a25cd593f51bc9f24f70\n  panleone:\n    utACK 67e632bd604588162d44a25cd593f51bc9f24f70 for making sure the wallet is unlocked before making a transaction.\n  Duddino:\n    ACK 67e632bd604588162d44a25cd593f51bc9f24f70\n  Liquid369:\n    ACK 67e632bd604588162d44a25cd593f51bc9f24f70\n\nTree-SHA512: 2b697793319fa64eb0806f685ab1be6a0e1e183734d5726974e16069a3442b52688436afc4b09c8488e361e036b89d5ffc5e8ab9d77ef0f97d1a79ea2321943e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2434102952\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2932\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2932/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2932\">#2932</a>: [Bug] Exit early for budget submission when the wallet i…"}},{"before":"9bc2ee2ab6cfaa01893110c3368175812f239c2d","after":"f855a9a948b0a8570aa237a646a239f93b1faea9","ref":"refs/heads/master","pushedAt":"2024-08-03T05:21:43.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2928: [Build] Autotools quoting and spacing cleanup\n\n3f1cf4196e19bfc9c3a0810b8af25d5618867e56 build: consistently quote BITCOIN_QT_FAIL() arguments (Fuzzbawls)\nb1591b473129ae23867b3273f549b56b88b7bb31 build: cleanup AC_ARG_WITH() usage (Fuzzbawls)\n04bc1e46280739a46f1b17d1082fa44c418f9731 build: consistently quote AC_ARG_ENABLE() arguments (Fuzzbawls)\n8f1e1b520c89bfc6957c3462699974ab1441165f build: consistently quote PKG_CHECK_MODULES() arguments (Fuzzbawls)\nca430070c49a36d3b5b01ff418f554066b86f011 build: consistently quote AC_CHECK_HEADER() arguments (Fuzzbawls)\n89c754087cc8bb4ae3041f2ba44cae3f7de7c8a0 build: consistently quote AC_SEARCH_LIBS() arguments (Fuzzbawls)\n6110f8af56b21419a7651cdb7ef7cdf0b856c8c7 build: consistently quote AC_CHECK_LIB() arguments (Fuzzbawls)\nf64eafdb04caeb24d6b868151021d8cbc286a75f build: consistently quote AC_MSG_*() arguments (Fuzzbawls)\n7ac518ed738f99f968456db71489ed833a044710 build: consistently quote AC_CHECK_PROG() arguments (Fuzzbawls)\ne7b80aae0bf023f996673e2d4ab1e221d548521c build: consistently quote AC_ARG_VAR() arguments (Fuzzbawls)\ndf371faf46ee8b7dbb582fe6ebc0712491c1467d build: consistently quote AM_CONDITIONAL() arguments (Fuzzbawls)\nef70fe31a7545d6f3e087fda117e805eaa743987 build: consistently quote AC_DEFINE() arguments (Fuzzbawls)\n6367c02dc5d9717364c60c3b30375047a6bb70f6 build: consistently quote AC_MSG_CHECKING() arguments (Fuzzbawls)\n820b05ed3e9238c4d620d0159eb1aa55da98ce8d build: consistently quote AC_PATH_TOOL() arguments (Fuzzbawls)\nbfd7a348e541dbd59a036c0dbacbf6b3afc630e8 build: consistently quote AC_PATH_PROG(S) arguments (Fuzzbawls)\nf9d61b4e4b97a46863b3f4f406ab82beca15c703 build: cleanup AX_CHECK_PREPROC_FLAG() usage (Fuzzbawls)\nee21875c2f2e04834963c2ef874337311e732c59 build: cleanup AX_CHECK_COMPILE_FLAG() usage (Fuzzbawls)\nfb145ee2c7cc37b61d7cb238957eb9879dd30487 build: cleanup AX_CHECK_LINK_FLAG() usage (Fuzzbawls)\n57569638724d67228153858f99eae2eeb4aa1626 build: Use dnl for all comments in configure.ac, rather than # (Fuzzbawls)\n\nPull request description:\n\n  This PR aims to clean up many of the autotools macros in terms of standardizing quoting and whitespace. No functionality is changed here.\n\n  A follow-up PR will improve readability of specific sections in `configure.ac`\n\nACKs for top commit: 3f1cf4196e19bfc9c3a0810b8af25d5618867e56\n  Liquid369:\n    utACK 3f1cf4196e19bfc9c3a0810b8af25d5618867e56\n  panleone:\n    utACK 3f1cf4196e19bfc9c3a0810b8af25d5618867e56,\n\nTree-SHA512: 6fbca4106e17040d5c308999238bf04be115dde93138ee8e814709b24cf258d3aaf6dc4002c667002d38939d34423ae0c5d48575f181bea2014425a0d35a3c53","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278890641\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2928\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2928/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2928\">#2928</a>: [Build] Autotools quoting and spacing cleanup"}},{"before":"27e639925782bfebc7c99ffc3905f819b1727ee1","after":"9bc2ee2ab6cfaa01893110c3368175812f239c2d","ref":"refs/heads/master","pushedAt":"2024-07-28T20:29:25.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2930: [GA] Fix minor issues with latest GA runner images\n\n92844cee275c14e7e2a2e740f4f1f59fe2cf8bc6 ga: Use runner provided rust for macOS (Fuzzbawls)\nde96bb413da36316def7e9d70ee7df6dc5d71d3f ga: Use python 3.10 on arm64 macos (Fuzzbawls)\n428ead2f3b6d60d2c34fd261d606254e44852b51 ga: Use runner image cached python versions (Fuzzbawls)\nc0ea7f0b17114f8a1d61997095c757b013f52350 ga: Update apt cache before environment setup (Fuzzbawls)\n8dd16415f2cc580e947da07eaeba172902e8a741 ga: explicitly export bdb flags for macos-12 runners (Fuzzbawls)\n\nPull request description:\n\n  Latest batch of GA runner images have introduced some more minor bugs that were preventing builds from finishing.\n\n  first two commits address the halting bugs, second two are a semi-related optimization.\n\nACKs for top commit: 92844cee275c14e7e2a2e740f4f1f59fe2cf8bc6\n  Liquid369:\n    tACK 92844cee275c14e7e2a2e740f4f1f59fe2cf8bc6\n  panleone:\n    utACK 92844cee275c14e7e2a2e740f4f1f59fe2cf8bc6\n\nTree-SHA512: bc075275f092e76c1a5f1fe24bd40fec9f4980700d305b859487909ac6f05d548027e789949375590ab2a539ab704200135d1c08682025794d719c099a5a9ff3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2361793175\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2930\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2930/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2930\">#2930</a>: [GA] Fix minor issues with latest GA runner images"}},{"before":"22a2fb84e78f5a5720bf3633ea854452ad7a6bcd","after":"27e639925782bfebc7c99ffc3905f819b1727ee1","ref":"refs/heads/master","pushedAt":"2024-04-25T08:37:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2926: [GA] Overhaul Github Actions Workflow\n\n3ba861c64ff35cc420f717b0286714d40457c2f0 [GA] Overhaul Github Actions Workflow (Fuzzbawls)\n\nPull request description:\n\n  This is a major overhaul of our GitHub Actions workflow file that introduces several cleanups and optimizations, as well as new jobs dedicated to running just the python functional test suite. Below are some of the more notable changes:\n\n  - Split off functional tests to their own jobs. Often times we will see a trivial failure in one of the functional tests. Prior to this change, this meant needing to re-run the entire build job again. With this change, we can trigger a re-run of just the functional test suite without needing to re-compile the wallet again. This is handled by creating a minimal archive \"artifact\" in the build job, and passing it to the new functional test jobs. Credit goes to @Duddino for coming up with this idea and doing much of the initial research and testing!\n  - Split old configure/build/unittest groupings into their own steps. Instead of exclusively relying on older group macros in a single step, I've created new more descriptive steps to improve readability and responsiveness of the actions report portal. This also helps in seeing where any significant bottle-neck is for a particular job configuration.\n  - Unify the `apt_get` and `brew_install` matrix config params. These two params have been unified to just `packages` across all matrix configurations.\n  - No longer cache the sapling params. Since the sapling params files are part of our source tree anyways, caching them in GitHub Actions cache files is redundant and only serves to waste valuable cache storage space.\n  - Add some basic descriptive commentary for jobs. Self-explanatory.\n\n  Note: The minimalist build artifacts are ONLY intended to be used within the GitHub Actions environment and expire after 5 days from their creation. Failing functional tests that are not resolved within this expiry time will necessitate a full re-run of the workflow. Any use of these artifacts outside of GitHub Actions is discouraged and unsupported.\n\n  ---\n  Reviewer's note: GitHub will report this PR as not having all the \"required checks\" as passing as the names/IDs of jobs have been changed. Once this PR is merged it will be then possible to update the repository settings to reflect the new job names/IDs in the \"required checks\" settings.\n\nACKs for top commit: 3ba861c64ff35cc420f717b0286714d40457c2f0\n  Duddino:\n    ACK 3ba861c64ff35cc420f717b0286714d40457c2f0\n  panleone:\n    utACK 3ba861c64ff35cc420f717b0286714d40457c2f0\n\nTree-SHA512: f5d7ff65c5dd37dc24c64dfa47038126923c92146a1fd61410e902cb452e350b49d65a9c8a55c1281b412713825ffc8d794d275519c632e4e2b541b0339cc54a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2242325119\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2926\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2926/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2926\">#2926</a>: [GA] Overhaul Github Actions Workflow"}},{"before":"4469fa046331b6b3b9404454bd912a18f39e8f9b","after":"22a2fb84e78f5a5720bf3633ea854452ad7a6bcd","ref":"refs/heads/master","pushedAt":"2024-04-25T06:43:50.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2925: [BUG] Fix more thread issues\n\nf5ba2649b014737ce2ec331b75f46cdeb9bde6a4 fix another possible deadlock (ale)\nf162f76229b7bd7e4c238df7feff28719ae23d11 fix: fix data race and remove circular dependency (ale)\n9207b8fdf55172ccc394c90b8e9b744106700c03 fix data race: LOCK cs before accessing nodeState (ale)\n58e5c8c425825dc3f8b0471480cdc5ea1065101c fix: Solve possible deadlock (ale)\n\nPull request description:\n\n  This PR fixes more thread issues that ThreadSanitizer showed:\n\n  first commit:\n  Solve a possible 3-threads deadlock fixed by locking `mempool.cs` before `cs_inventory` (see the comment for the log)\n\n  second commit:\n  solve the trivial data race where `nodeState` is accessed without locking the corresponding mutex\n\n  third commit:\n  solve all the issues that the function `getQuorumNodes` had:\n\n  - `it` iterator was accessed without having the lock on `cs_vPendingMasternodes` which was causing a possible data race\n  - `connman->vNodes`  was accessed without locking the mutex `cs_vNodes` (another possible data race)\n\n   Solved by using the function `connman->ForEachNode` and removing the useless getter.\n\n  fourth commit:\n  Solve a possible deadlock: lock `cs_vPendingMasternodes` before calling `connmann->ForEachNode(...)`\n\nACKs for top commit: f5ba2649b014737ce2ec331b75f46cdeb9bde6a4\n  Liquid369:\n    tACK f5ba2649b014737ce2ec331b75f46cdeb9bde6a4\n  Fuzzbawls:\n    ACK f5ba2649b014737ce2ec331b75f46cdeb9bde6a4\n\nTree-SHA512: 2fa61ec6b3ad395cbe968874a90f1ec16eb5ddec85d48ddeb438fc92f4ae281d4ff7c5b297b147c4b3bf60d6a4849c0619567e3beccb930a76f61d0815bea1d5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2231562574\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2925\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2925/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2925\">#2925</a>: [BUG] Fix more thread issues"}},{"before":"afb54472482bd8c567c63fc6be20c0d241b417d4","after":"4469fa046331b6b3b9404454bd912a18f39e8f9b","ref":"refs/heads/master","pushedAt":"2024-04-20T08:01:33.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2924: [Bug] Fix validation interface data race\n\nddbd4b01549999efa183373e349fc963d0f76aa2 fix BlockStateCatcher data races (ale)\nb01c3df1bdd083be2e7723e0361bffe396a9337b let validationinterface take shared_ptr (ale)\n\nPull request description:\n\n  first commit:\n  Partially backport bitcoin PR https://github.com/bitcoin/bitcoin/pull/18338 which introduce the functions\n  `RegisterSharedValidationInterface` and `UnregisterSharedValidationInterface`.  See that PR why using normal pointers is problematic, and how `shared_ptr` solve the issue\n  (In a few words the problem is that it can happen that the pointed memory is freed before all signals have been processed, while with shared pointer we are sure that  memory will be freed after the last signal is handled)\n\n  second commit:\n  Utilize the new functions to the validation interface `BlockStateCatcher`.  In order to keep everywhere the logic unchanged (Registering on creation and Unregistering when the object goes out of scope) I created the wrapper class `BlockStateCatcherWrapper` which contains a `shared_ptr` to `BlockStatecatcher`.\n\n  Those two commits solve the following data race where a `BlockStateCatcher` pointer is dereferenced after the pointed memory is freed\n\n  ```\n  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=6423)\n    Write of size 8 at 0x7fc3d7c2d570 by thread T20:\n      #0 CValidationInterface::~CValidationInterface() validationinterface.h:75 (pivxd+0xeacac)\n      #1 BlockStateCatcher::~BlockStateCatcher() util/blockstatecatcher.h:23 (pivxd+0xeacac)\n      #2 generateBlocks(Consensus::Params const&, CWallet*, bool, int, int, int, CScript*) rpc/mining.cpp:78 (pivxd+0x1c1a98)\n      #3 generate(JSONRPCRequest const&) rpc/mining.cpp:140 (pivxd+0x1c2215)\n      ...\n\n    Previous read of size 8 at 0x7fc3d7c2d570 by thread T35 (mutexes: write M133270, write M132847):\n      #0 void std::__invoke_impl<void, void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>(std::__invoke_memfun_deref, void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*&&) /usr/include/c++/12/bits/invoke.h:74 (pivxd+0x2eef14)\n      #1 std::__invoke_result<void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>::type std::__invoke<void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>(void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*&&) /usr/include/c++/12/bits/invoke.h:96 (pivxd+0x2eefbb)\n      #2 void std::_Bind<void (CValidationInterface::*(CValidationInterface*, std::_Placeholder<1>))(CConnman*)>::__call<void, CConnman*&&, 0ul, 1ul>(std::tuple<CConnman*&&>&&, std::_Index_tuple<0ul, 1ul>) /usr/include/c++/12/functional:484 (pivxd+0x2eefbb)\n      ...\n     ```\n\nACKs for top commit: ddbd4b01549999efa183373e349fc963d0f76aa2\n  Duddino:\n    utACK ddbd4b01549999efa183373e349fc963d0f76aa2\n  Liquid369:\n    tACK ddbd4b01549999efa183373e349fc963d0f76aa2\n\nTree-SHA512: 94d55effc11f14f755f27c30ef1b6801a235bc314cc34312ebb14b75525824d3b11bb7812389d9977c30a0929d62fb745bd5c1a15249708014bd573132a5e55c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2229346712\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2924\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2924/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2924\">#2924</a>: [Bug] Fix validation interface data race"}},{"before":"694eb5987028efba63145355ca7f54073e07fc4c","after":"afb54472482bd8c567c63fc6be20c0d241b417d4","ref":"refs/heads/master","pushedAt":"2024-04-20T06:58:53.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2918: [Build] Update m4 macros from upstream\n\n90b1892c5a402537b0eee5197344e6c4c8dbc964 build: AX_BOOST_UNIT_TEST_FRAMEWORK() serial 22 (Fuzzbawls)\n92d478cbd8ff7899298649cf7a9b5a1897fdf5b6 build: AX_BOOST_THREAD() serial 33 (Fuzzbawls)\n103b802de4e61ed4dbb2b32ae634ea2cc39b96a4 build: AX_BOOST_SYSTEM() serial 20 (Fuzzbawls)\n1712d9a7f5a7ad4914c9c3c39f4e9475ddd2f3dd build: AX_BOOST_FILESYSTEM() serial 28 (Fuzzbawls)\n583adf64fbd2eeb1af0a7b35481f239331dedfa1 build: AX_BOOST_CHRONO() serial 5 (Fuzzbawls)\n7d93e29a7a2ce203283daefc4da451a33da5a61c build: AX_BOOST_BASE() serial 54 (Fuzzbawls)\n076fbf407a7ea159c01c65dd4417e0c9db86a48f build: AX_PTHREAD() serial 31 (Fuzzbawls)\n8813235b8b8c57326b06b3e7fe53b4c45891026a build: AX_GCC_FUNC_ATTRIBUTE() serial 13 (Fuzzbawls)\n3596f0f2699f5024f93a6e36862186af9f4b099a build: AX_CXX_COMPILE_STDCXX() serial 18 (Fuzzbawls)\n52a11ff981bd0bc25b1e4c8025103d5083d42758 build: AX_CHECK_PREPROC_FLAG() serial 6 (Fuzzbawls)\n3200d3f38d5511d31eb1781a46360383db6e33ee build: AX_CHECK_LINK_FLAG() serial 6 (Fuzzbawls)\nfd783608a25d32cb16cbcf1fae3c1dd7ed6c9e61 build: AX_CHECK_COMPILE_FLAG() serial 6 (Fuzzbawls)\n\nPull request description:\n\n  This is the first part in what will be a series of updates to our autotools build system. these commits are simply updating macro scripts from their upstream published versions. the only manual change that i've made is to ensure there is a new line at the bottom of each file.\n\nACKs for top commit: 90b1892c5a402537b0eee5197344e6c4c8dbc964\n  panleone:\n    utACK 90b1892c5a402537b0eee5197344e6c4c8dbc964,\n  Liquid369:\n    tACK 90b1892c5a402537b0eee5197344e6c4c8dbc964\n\nTree-SHA512: 273dec63811972835802ee890206e159494ec8934dac4e570bb74013473b4716022dcc933e593ab4634334a2acabf81e4e94df99d4d96b3aeaa6f328468bd7e1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2207023209\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2918\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2918/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2918\">#2918</a>: [Build] Update m4 macros from upstream"}},{"before":"db78a7ec2d9ffbb49293862c9b7fd091e6ad5f82","after":"694eb5987028efba63145355ca7f54073e07fc4c","ref":"refs/heads/master","pushedAt":"2024-04-20T06:53:42.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2923: [Bug] Fix wallet data race\n\nf9a6ebddfa27e1678e464a249759cfe1649143d1 fix: solve data race by making nTimeBestReceived atomic (ale)\n4331c3007b1211998d74a66e908f2de7c82ec564 refactor: move nTimeBestReceived to CWallet (ale)\n\nPull request description:\n\n  First commit is a small refactor:  the global variable `nTimeBestReceived` is now a private member of the `CWallet` class, as it was used only there.\n\n  Second commit: fix the following data race by making `nTimeBestReceived` atomic\n\n  ```\n  WARNING: ThreadSanitizer: data race (pid=18270)\n    Write of size 8 at 0x7b6800000ed8 by thread T16:\n      #0 CWallet::UpdatedBlockTip(CBlockIndex const*, CBlockIndex const*, bool) wallet/wallet.cpp:2094 (pivxd+0x5058c9)\n      #1 void std::__invoke_impl<void, void (CValidationInterface::*&)(CBlockIndex const*, CBlockIndex const*, bool), CValidationInterface*&, CBlockIndex const*, CBlockIndex const*, bool>(std::__invoke_memfun_deref, void (CValidationInterface::*&)(CBlockIndex const*, CBlockIndex const*, bool), CValidationInterface*&, CBlockIndex const*&&, CBlockIndex const*&&, bool&&) /usr/include/c++/12/bits/invoke.h:74 (pivxd+0x2ee1c0)\n      #2 std::__invoke_result<void (CValidationInterface::*&)(CBlockIndex const*, CBlockIndex const*, bool), CValidationInterface*&, CBlockIndex const*, CBlockIndex const*, bool>::type std::__invoke<void (CValidationInterface::*&)(CBlockIndex const*, CBlockIndex const*, bool), CValidationInterface*&, CBlockIndex const*, CBlockIndex const*, bool>(void (CValidationInterface::*&)(CBlockIndex const*, CBlockIndex const*, bool), CValidationInterface*&, CBlockIndex const*&&, CBlockIndex const*&&, bool&&) /usr/include/c++/12/bits/invoke.h:96 (pivxd+0x2ee25a)\n      #3 void std::_Bind<void (CValidationInterface::*(CValidationInterface*, std::_Placeholder<1>, std::_Placeholder<2>, std::_Placeholder<3>))(CBlockIndex const*, CBlockIndex const*, bool)>::__call<void, CBlockIndex const*&&, CBlockIndex const*&&, bool&&, 0ul, 1ul, 2ul, 3ul>(std::tuple<CBlockIndex const*&&, CBlockIndex const*&&, bool&&>&&, std::_Index_tuple<0ul, 1ul, 2ul, 3ul>) /usr/include/c++/12/functional:484 (pivxd+0x2ee25a)\n      ...\n\n    Previous read of size 8 at 0x7b6800000ed8 by thread T35 (mutexes: write M134298, write M132880):\n      #0 CWallet::ResendWalletTransactions(CConnman*) wallet/wallet.cpp:2065 (pivxd+0x515b25)\n      #1 void std::__invoke_impl<void, void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>(std::__invoke_memfun_deref, void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*&&) /usr/include/c++/12/bits/invoke.h:74 (pivxd+0x2eef45)\n      #2 std::__invoke_result<void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>::type std::__invoke<void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*>(void (CValidationInterface::*&)(CConnman*), CValidationInterface*&, CConnman*&&) /usr/include/c++/12/bits/invoke.h:96 (pivxd+0x2eefb9)\n      #3 void std::_Bind<void (CValidationInterface::*(CValidationInterface*, std::_Placeholder<1>))(CConnman*)>::__call<void, CConnman*&&, 0ul, 1ul>(std::tuple<CConnman*&&>&&, std::_Index_tuple<0ul, 1ul>) /usr/include/c++/12/functional:484 (pivxd+0x2eefb9)\n      ...\n  ```\n\nACKs for top commit: f9a6ebddfa27e1678e464a249759cfe1649143d1\n  Duddino:\n    utACK f9a6ebddfa27e1678e464a249759cfe1649143d1\n  Liquid369:\n    tACK f9a6ebddfa27e1678e464a249759cfe1649143d1\n  Fuzzbawls:\n    ACK f9a6ebddfa27e1678e464a249759cfe1649143d1\n\nTree-SHA512: c1de883956bf0958204b05c338831c27f694e6453e74b77e3347ae12a3cbd69df2fe1120bae3fca72dab14587c0c499c4f92d5c53943305855e66fc1275ab4fa","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2228549114\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2923\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2923/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2923\">#2923</a>: [Bug] Fix wallet data race"}},{"before":"f428a7429c89f685c2468cf4ff3c8b9d92047950","after":"db78a7ec2d9ffbb49293862c9b7fd091e6ad5f82","ref":"refs/heads/master","pushedAt":"2024-04-06T20:28:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2922: [GA] Bump native macOS runner versions\n\n454fbfd858f282858b372361b660ac79d35d327b [GA] Bump native macOS runner versions (Fuzzbawls)\n\nPull request description:\n\n  A recent 3rd party server outage for the miniupnpc library has caused macOS 11 jobs to fail. While the homebrew package manager for macOS has fixed the issue on their end, GitHub has no clear intention to update their macOS 11 runner image due to macOS 11 runners already being deprecated.\n\n  macOS 11 support will be removed from GA completely on June, 28 2024. Pre-emptively bump the os runner versions we use to macOS 12 and macOS 14 (the latter of which runs on Apple's new CPU architecture).\n\n  Relevant and required build system changes have also been applied to support the new macOS 14 runner environment.\n\nACKs for top commit: 454fbfd858f282858b372361b660ac79d35d327b\n  panleone:\n    utACK 454fbfd858f282858b372361b660ac79d35d327b\n  Liquid369:\n    tACK 454fbfd858f282858b372361b660ac79d35d327b\n\nTree-SHA512: bb5b1965ae99b9e7eda0d464d07b1d8226a00a0aa27be84b2d7cf18f265ecdd759b5eaeba83316a75376100f8a37bb61fe96048a40746ed71febb3e2505cedd8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2227095048\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2922\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2922/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2922\">#2922</a>: [GA] Bump native macOS runner versions"}},{"before":"7954d0a65160712a646633774baf073012e82917","after":"f428a7429c89f685c2468cf4ff3c8b9d92047950","ref":"refs/heads/master","pushedAt":"2024-04-04T07:10:01.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2920: [Http] [Test]  Fix test failures on shutdown\n\n05c30a84fb834db3a6945585fad9994607cc5610 Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error (MarcoFalke)\ncb65d0af5492d917d394e0aab70668764a35dd3d Merge #14993: rpc: Fix data race (UB) in InterruptRPC() (Wladimir J. van der Laan)\ncf6cb299c165c491994a75dc984ae6d3362278ab Merge #14670: http: Fix HTTP server shutdown (Wladimir J. van der Laan)\nd19d9faad595fa54a03a244eb7efa1219bb3a926 Call RPCNotifyBlockChange on RPC stopped (ale)\naf10755fcd0795524de6321a20239b8189cd52b5 Merge #11006: Improve shutdown process (Wladimir J. van der Laan)\n\nPull request description:\n\n  The aim of this PR is fixing the functional test errors that we get sometimes during shutdown, for example the failure of this action  https://github.com/PIVX-Project/PIVX/actions/runs/8429115630/job/23082877380\n\n  In a few words, on HTTP server shutdown, sometimes 2 seconds are not enough time to finish handling all the RPC requests.\n\n  `2024-03-26T01:35:26Z HTTP event loop did not exit within allotted time, sending loopbreak`\n\n  So after this point all existing RPC requests (in particular the `stop()` one) does not receive any answer...  And this lead to functional tests failing at the end.\n\n  For more info see the discussion in each backported PR.\n\n  Backport bitcoin PRs #11006 #14670 #14993 #14413\n\nACKs for top commit: 05c30a84fb834db3a6945585fad9994607cc5610\n  Liquid369:\n    tACK 05c30a84fb834db3a6945585fad9994607cc5610\n  Fuzzbawls:\n    ACK 05c30a84fb834db3a6945585fad9994607cc5610\n\nTree-SHA512: 3fa2d7d9f11f851dbf3703a70e45a12905cb801156b32654f624487c386d76d4eebbc9d54418f4fbe0ac500afeed626636cda2dc942294ea991ff5cde47b07f4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2207786784\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2920\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2920/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2920\">#2920</a>: [Http] [Test] Fix test failures on shutdown"}},{"before":"e4f61cddfb5a7150fd72d3c9a96847f1e780e86e","after":"7954d0a65160712a646633774baf073012e82917","ref":"refs/heads/master","pushedAt":"2024-04-02T09:35:54.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2917: [LLMQ] Improve thread handling\n\n44116cf9f0eaf9855d10aeb179990b72dd79b556 Separate Init from Start and Stop from Destroy functions for Chainlock handler (ale)\n581eabebe97e463543e9e69aa436c0ee853d7664 Add Interrupt step for signing_share thread and do NOT call StopWorkerThread twice (ale)\n8e85ca21ea94a8a25f4567fea487c695b8700fd1 promote chainLocksHandler to unique pointer (ale)\n4f579eb29177a6e5d269c48dbe94987d27e32d20 promote quorumSigningManager to unique pointer (ale)\n4820a6338ba15c2f41099af3508519d97f60a016 promote quorumSigSharesManager to unique pointer (ale)\n\nPull request description:\n\n  Fix some issues in the LLMQ threads handling, that might be also causing some problems in some tests that randomly fail during the final `ShutDown()` phase.\n\n  First 3 commits are just trivial refactor:\n  Use unique pointers in place of normal pointers to be consistent with the style used for other llmq managers.\n\n  Fourth commit:\n  In `CSigSharesManager` the function `StopWorkerThread()` was being called twice. The wrong call was the one in the destructor which has been removed.\n  The rest of the diff is basically a copy and paste from [net_masternodes.cpp](https://github.com/PIVX-Project/PIVX/blob/master/src/tiertwo/net_masternodes.cpp) (the variable `interruptNet` of that file plays the exact same role of the variable `interruptSigningShare` that I have added).\n  This new version should be the right way to manage the thread\n\n  Fifth commit:\n  In the chainlock manager split the `Init` from the `Start` and the `Stop` from the `Destroy` phases, as we do for all other llmq managers.\n\nACKs for top commit: 44116cf9f0eaf9855d10aeb179990b72dd79b556\n  Duddino:\n    utACK 44116cf9f0eaf9855d10aeb179990b72dd79b556\n  Liquid369:\n    tACK 44116cf9f0eaf9855d10aeb179990b72dd79b556\n  Fuzzbawls:\n    ACK 44116cf9f0eaf9855d10aeb179990b72dd79b556\n\nTree-SHA512: 41a432781861753ce29904093fc6f8771d8745babd498526c5fa6890703de96078c6a242c42ebc292ddefa0c5c0488effb8f6f367771af229f066132a8004eba","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2206698636\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2917\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2917/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2917\">#2917</a>: [LLMQ] Improve thread handling"}},{"before":"d75c161090d8831a2fd27bc874a0fd6f0eb98a83","after":"e4f61cddfb5a7150fd72d3c9a96847f1e780e86e","ref":"refs/heads/master","pushedAt":"2024-04-02T05:24:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2916: [Test] speed un tiertwo_governance_sync_basic\n\n471cae3838f4a0c133fff7800162df816bf90567 Do not sleep after staking and after sending pings (ale)\n\nPull request description:\n\n  `tiertwo_governance_sync_basic` is by far the slowest test that we have. Profiling showed that most of the time was spent in the function stake() which slept for a total of 2 seconds in each call.\n\n  Those 2 seconds sleep were actually useless and have been removed.\n  With this simple change the total running time of the test on my machine dropped from `15` minutes to only `6` minutes.\n\n  To prove that indeed sleeping was useless I tried to run the same test in parallel 15 times, and it never failed, see here:\n  https://github.com/panleone/PIVX/actions/runs/8420343441\n\nACKs for top commit: 471cae3838f4a0c133fff7800162df816bf90567\n  Duddino:\n    utACK 471cae3838f4a0c133fff7800162df816bf90567\n  Liquid369:\n    tACK 471cae3838f4a0c133fff7800162df816bf90567\n  Fuzzbawls:\n    ACK 471cae3838f4a0c133fff7800162df816bf90567\n\nTree-SHA512: 6b00a18c7edd6dffaf9c5df3f53c8481c4312f7d8a63819010289c17b5ab7715aeafb901c8da885515fa59a093ab6e101c572972823ac2ca5e5c53139921f063","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2205900291\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2916\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2916/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2916\">#2916</a>: [Test] speed un tiertwo_governance_sync_basic"}},{"before":"75ad9145ac5e569954127ad3fa36f2e805bc811e","after":"d75c161090d8831a2fd27bc874a0fd6f0eb98a83","ref":"refs/heads/master","pushedAt":"2024-03-30T06:40:37.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2915: [Test] [DMNs] Split special transaction validation\n\n607ba813f69139ecc7246431855be7c5b8b657d0 test: add trivial validation invalid tests (ale)\n2c87e7863fa2360a4b022629da4371946aef3c19 test: add trivial validation tests (ale)\n325a204e97238ca13352d43e8f7cfc1680f589f0 Verify match between type and tx version in GetValidatedTxPayload (ale)\nbf373bf1aee415a954b5a18aa410580c3a8f23cc Refactor special_tx_validation (ale)\n78c7d266f7e8c041fd12adbe9200c169241a3a7a Add SPECIAL_TX_TYPE member to payload classes (ale)\n357f572d1b0694bdc6832d5dd5390e861c36a63b Add IsTriviallyValid for special payloads (ale)\n\nPull request description:\n\n  First 4  commits are a (almost) move only  refactor:\n  The self contained part of special transaction validation (i.e the part based only on specialtx info and not on full chain and masternode list) has been moved to functions `IsTriviallyValid`.\n\n  Last 2 commits improve unit test coverage:\n  I have added two files with a list of special txs which are either valid or invalid.  Test consist in correctly deserializing the txs and verifying that valid/invalid ones are indeed considered valid/invalid.\n\nACKs for top commit: 607ba813f69139ecc7246431855be7c5b8b657d0\n  Liquid369:\n    tACK 607ba813f69139ecc7246431855be7c5b8b657d0\n  Duddino:\n    utACK 607ba813f69139ecc7246431855be7c5b8b657d0\n  Fuzzbawls:\n    ACK 607ba813f69139ecc7246431855be7c5b8b657d0\n\nTree-SHA512: 59a810d49c17943e2dfc10d95e7886922b42cfa2c91b6f8d77d64aa2a386fdebe137c11eb8f93188d79fcd0bae42aceeb2fc3d63af2a3abc1b2ac1cf103d31ea","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2204383500\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2915\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2915/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2915\">#2915</a>: [Test] [DMNs] Split special transaction validation"}},{"before":"efaa521c8b8a4846781ec7e4c0a701b9240a9a7c","after":"75ad9145ac5e569954127ad3fa36f2e805bc811e","ref":"refs/heads/master","pushedAt":"2024-03-30T06:31:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2919: [Bug] Fix data race\n\n35c9b1efd3edcccde1b67bd0358e90ae1f9a80e3 Fix data race (ale)\n\nPull request description:\n\n  Fix the data race in which a thread is trying to write `pcoinsTip.cacheSaplingAnchors`:\n  `CWallet::BlockConnected -> pcoinsTip->GetSaplingAnchorAt(...)`\n  At the same time another thread is trying to read `pcoinsTip.cacheSaplingAnchors`:\n  `ActivateBestChain -> FlushStateToDisk -> pcoinsTip->DynamicMemoryUsage()`.\n\n  The fix is trivial `CWallet::BlockConnected` was not locking the mutex `cs_main` that guards `pcoinsTip`.\n\n  This data race was causing the functional test `wallet_basic.py` to randomly fail: To see this I created two test branches where I ran `wallet_basic.py` 50 times in parallel. One branch has this fix the other doesn't.\n\n  The github action for the branch without this fix failed many times\n  https://github.com/panleone/PIVX/actions/runs/8428460478\n\n  The github action for the branch with this fixed always passed instead\n  https://github.com/panleone/PIVX/actions/runs/8428472901\n\nACKs for top commit: 35c9b1efd3edcccde1b67bd0358e90ae1f9a80e3\n  Duddino:\n    utACK 35c9b1efd3edcccde1b67bd0358e90ae1f9a80e3\n  Liquid369:\n    tACK 35c9b1efd3edcccde1b67bd0358e90ae1f9a80e3\n  Fuzzbawls:\n    ACK 35c9b1efd3edcccde1b67bd0358e90ae1f9a80e3\n\nTree-SHA512: a5cea7f1b1478045f0e642c306f8f0427a10e92a13cc61e830bb214d4c5d1ba234cba1f628606ee02d0acc68c2719a981433f84fadbbd559af885e14e6353489","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2207506680\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2919\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2919/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2919\">#2919</a>: [Bug] Fix data race"}},{"before":"4c2ed24c6cd7e3974c03fb015e8b5bf01b8803b9","after":"efaa521c8b8a4846781ec7e4c0a701b9240a9a7c","ref":"refs/heads/master","pushedAt":"2024-03-23T05:29:48.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2914: [Test] Speed up functional tests\n\n26ed4d4835f95d70f4e4a470424806ab6e508215 Do not arbitrarily sleep when waiting for all messages (Alessandro Rezzi)\n82a36fde143426d03a1c59973fad31da0fca58dd remove many other useless time.sleep (Alessandro Rezzi)\n310ebd1f1c76e844ec4bce20b862670981ac8247 Do not sleep in is_node_stopped (Alessandro Rezzi)\n998233efd1e692dce6ef7273c1952d3b140d3918 Connect all nodes in parallel (Alessandro Rezzi)\necc512073f2935a31a1175ea80c32e00112fc53c test: Do not sleep inside wait_for_rpc_connection (Alessandro Rezzi)\n\nPull request description:\n\n  The aim of this PR is making functional test run faster\n\n  First commit:\n  Sleeping inside `wait_for_rpc_connection`  is useless since in case of failure it will try again rather than throwing error.\n\n  Second commit:\n  profiling showed that waiting for all nodes to connect to each other was very slow (`8` nodes took about ~`32` seconds on my PC). If we connect them in parallel time is much faster ( more or less `4` seconds on my PC)\n\n  Third commit:\n  sleeping inside `is_node_stopped` is useless since it is always used in operations like `wait_until_stopped`, and in case a node is not stopped it will wait and try again rather than throwing error.\n\n  Fourth commit:\n  removed many other big `time.sleep()` that made everything go overall much slower. This is the only commit that I'm not 100% sure so if we see that some test fail at the beginning (I mean before `run_test()` is called) this one can be reverted.\n\n  Fifth commit:\n  Make faster and solve the failure of `p2p_invalid_messages.py`:\n  When receiving lots of messages use a timeout system, instead of sleeping for an arbitrary amount of time (30 seconds, which sometimes was not enough)\n\nACKs for top commit: 26ed4d4835f95d70f4e4a470424806ab6e508215\n  Liquid369:\n    tACK 26ed4d4835f95d70f4e4a470424806ab6e508215\n  Duddino:\n    utACK 26ed4d4835f95d70f4e4a470424806ab6e508215\n  Fuzzbawls:\n    ACK 26ed4d4835f95d70f4e4a470424806ab6e508215\n\nTree-SHA512: e0da682fa0c5f53e7c4179e00f4afe23455353326383ff36ee0459ccc8b175f12dc9da330086faf3ce596487927bc7fba30aa5f6bef9b5c8ff130da3d8228eaa","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2197680481\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2914\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2914/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2914\">#2914</a>: [Test] Speed up functional tests"}},{"before":"71db39899744ae5c3f526f7c8e88c1b8a23ef743","after":"4c2ed24c6cd7e3974c03fb015e8b5bf01b8803b9","ref":"refs/heads/master","pushedAt":"2024-03-22T05:06:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2912: [Build] Bump master to 5.6.99\n\n2f5249c0422fe4e2bb95cb5b60fcc739c1d84f40 [Build] Bump master to 5.6.99 (Fuzzbawls)\n\nPull request description:\n\n  Bumps `master` branch to 5.6.99 now that 5.6.1 has been released.\n\nACKs for top commit: 2f5249c0422fe4e2bb95cb5b60fcc739c1d84f40\n  panleone:\n    utACK 2f5249c0422fe4e2bb95cb5b60fcc739c1d84f40\n  Liquid369:\n    tACK 2f5249c0422fe4e2bb95cb5b60fcc739c1d84f40\n\nTree-SHA512: ce4abe4e196177100f59f7c54e033937010a4baf3b79b1cbc0b3d73beb58b7120bcd13a66132c815ddfa7c5a65b824c96a479bed8258a9cdc490bc87e438eb99","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2168731838\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2912\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2912/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2912\">#2912</a>: [Build] Bump master to 5.6.99"}},{"before":"ae754446d0ce5a46f467b6a3332afcad47a8865e","after":"71db39899744ae5c3f526f7c8e88c1b8a23ef743","ref":"refs/heads/master","pushedAt":"2024-03-22T05:03:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2909: [Trivial] Fix typo reccomended->recommended\n\n1259086221eaa06d9bb48e7fef16aa6493055999 [Trivial] Fix typo reccomended->recommended (Duddino)\n\nPull request description:\n\n  Codespell complained of this typo\n\nACKs for top commit: 1259086221eaa06d9bb48e7fef16aa6493055999\n  Fuzzbawls:\n    ACK 1259086221eaa06d9bb48e7fef16aa6493055999\n  panleone:\n    utACK 1259086221eaa06d9bb48e7fef16aa6493055999\n\nTree-SHA512: a247bb2f1ef51e3f2630a08043963833adb1b12c3b9b50322f330a9f1dd7273dbb8987e1f0444869bab513c079c5c272fd52236f946b08395a2552f261eda13c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2143965224\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2909\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2909/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2909\">#2909</a>: [Trivial] Fix typo reccomended-&gt;recommended"}},{"before":"8c359dd303417722e4563d41692ecf8cae323449","after":"ae754446d0ce5a46f467b6a3332afcad47a8865e","ref":"refs/heads/master","pushedAt":"2024-03-21T05:02:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2911: [GA] Use new versioned qt@5 homebrew package name\n\n9e6d17b9392223f79bc08bce5d55d4b84ebe724d [GA] Use new versioned qt@5 homebrew package name (Fuzzbawls)\n\nPull request description:\n\n  Homebrew recently removed the legacy symlinks for the `qt5` package and is now only using the versioned `qt@5` naming. Adjust accordingly.\n\nACKs for top commit: 9e6d17b9392223f79bc08bce5d55d4b84ebe724d\n  panleone:\n    tACK 9e6d17b9392223f79bc08bce5d55d4b84ebe724d\n  Liquid369:\n    tACK 9e6d17b9392223f79bc08bce5d55d4b84ebe724d\n\nTree-SHA512: e3a1f499326afc5bde8b60e49709c58ddbf3d86f7316730b6884e049b35f6f5ecdaa726339baf2aeb671abb14a1d13a6e78870a7dc9d8b48e1427571ccbc3a41","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2168715633\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2911\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2911/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2911\">#2911</a>: [GA] Use new versioned qt@5 homebrew package name"}},{"before":"7d134c64139aaba58b118e3dc8cd73ebbda24121","after":"af60f19642c6356061049df253e8036e81879f4e","ref":"refs/heads/5.6","pushedAt":"2024-02-20T21:19:31.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Build: generate 5.6.1 manpages","shortMessageHtmlLink":"Build: generate 5.6.1 manpages"}},{"before":"4ca4c397ecaf101916ce3cc3d0a6ca119f93ec0d","after":"8c359dd303417722e4563d41692ecf8cae323449","ref":"refs/heads/master","pushedAt":"2024-02-20T20:40:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2908: [Core] Fix Exchange address activation\n\nd7d30dcc4dbeddd8c0c8c348528df5913912ce46 Change exchange address functional tests (Duddino)\n6c012831735b0e8b5c1a73eb9db5f643341a5529 Fix Exchange address activation (Duddino)\n\nPull request description:\n\n  Change exchange address activation with the following:\n  - Before 5.6 activation, accept TxOuts with OP_EXCHANGEADDR, even if they have sapling data in it\n  - Before 5.6 activation, treat OP_EXCHANGEADDR as OP_UNKNOWN, thus rejecting any attempt at spending them\n  - After 5.6 activation, keep things as is (Don't accept exchange address UTXOs if the tx has sapling data)\n\nACKs for top commit: d7d30dcc4dbeddd8c0c8c348528df5913912ce46\n  Liquid369:\n    tACK d7d30dcc4dbeddd8c0c8c348528df5913912ce46\n  panleone:\n    utACK d7d30dcc4dbeddd8c0c8c348528df5913912ce46\n\nTree-SHA512: 34f2cb7e8c2ce71c3e4fcc6fd977853e4828381e23a65b85cc8f86b95da7fe640b1d28c337d9f32df4d8d833225794a8cd1120474c1ab2c58062afc55612f3b5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2142912056\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2908\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2908/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2908\">#2908</a>: [Core] Fix Exchange address activation"}},{"before":"8df4dc00e2970458c6c170336bb801450828c702","after":"4ca4c397ecaf101916ce3cc3d0a6ca119f93ec0d","ref":"refs/heads/master","pushedAt":"2024-02-20T06:38:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2906: Fix optional memo not being checked\n\nb0bf2c22e54eceaf8b2f117bf2dffb9ecd358227 Fix optional memo not being checked (Duddino)\n\nPull request description:\n\n  Memos return Nullopt instead of empty string when empty.\n\nACKs for top commit: b0bf2c22e54eceaf8b2f117bf2dffb9ecd358227\n  Liquid369:\n    tACK b0bf2c22e54eceaf8b2f117bf2dffb9ecd358227\n  Fuzzbawls:\n    utACK b0bf2c22e54eceaf8b2f117bf2dffb9ecd358227\n\nTree-SHA512: e9e6cd99edaa6d56da59abdfcc4056d2d613cad93203f47d3fc3c65763413e3eef8df50773a82f934fd5e912ae94579a71a5805f30eb00964f71ebd5eb6d271a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2141235816\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2906\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2906/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2906\">#2906</a>: Fix optional memo not being checked"}},{"before":"3f6c48b207ed121c951547e1700468be3ec7c583","after":"8df4dc00e2970458c6c170336bb801450828c702","ref":"refs/heads/master","pushedAt":"2024-02-20T06:35:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2905: Restore Mainnet 'EXM' Prefix\n\n54459570903430276539b1836f7d26142ee29e46 Set Mainnet 'EXM' Prefix (Liquid)\n\nPull request description:\n\n  This will restore the Mainnet prefix to `EXM` from the current `EX` setting that is returning `44` in production.\n\nACKs for top commit: 54459570903430276539b1836f7d26142ee29e46\n  Duddino:\n    tACK 54459570903430276539b1836f7d26142ee29e46\n  Fuzzbawls:\n    ACK 54459570903430276539b1836f7d26142ee29e46\n\nTree-SHA512: cb0e34cf0899768a1d69fea1c95912dd11bd97a10e294dbcb25435bf42f1a6f599091e9a4ca1c14ea224864b687fca8d03f0e40f0c2e91575eff6eee5615cc9d","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2141153058\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2905\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2905/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2905\">#2905</a>: Restore Mainnet 'EXM' Prefix"}},{"before":"9a60dd86d7d17f4aa922c69831950a3a997cb2a1","after":"3f6c48b207ed121c951547e1700468be3ec7c583","ref":"refs/heads/master","pushedAt":"2024-02-19T17:14:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2904: Fix unititialized booleans\n\n1021b81147825be8e1252dc20be5ca6220e72254 Fix unititialized booleans (Duddino)\n\nPull request description:\n\n  This PR fixes some uninitialized booleans. This fixes the issue of not being able to send to addresses in the qt version of PIVX\n\nACKs for top commit: 1021b81147825be8e1252dc20be5ca6220e72254\n  Fuzzbawls:\n    utACK 1021b81147825be8e1252dc20be5ca6220e72254\n  Liquid369:\n    tACK 1021b81147825be8e1252dc20be5ca6220e72254\n\nTree-SHA512: e51ce738d2c13cc7a1c2ac80ab2c880457d9600869940b3893e1b9836257c1f60b3f6c3abcccd485309fe506bd0c16bb7d0a810ed2f3de6471e44d19170344ef","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2141149047\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2904\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2904/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2904\">#2904</a>: Fix unititialized booleans"}},{"before":"e44ebdc647d2e7354eba50caff30204125c35437","after":"7d134c64139aaba58b118e3dc8cd73ebbda24121","ref":"refs/heads/5.6","pushedAt":"2024-02-17T03:55:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Doc: update manpages for 5.6.0","shortMessageHtmlLink":"Doc: update manpages for 5.6.0"}},{"before":"b2987da88f3d91d9e52f3d75c4c7f2eeb2651eba","after":"e44ebdc647d2e7354eba50caff30204125c35437","ref":"refs/heads/5.6","pushedAt":"2024-02-17T03:45:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Doc: update manpages for 5.6.0","shortMessageHtmlLink":"Doc: update manpages for 5.6.0"}},{"before":null,"after":"b2987da88f3d91d9e52f3d75c4c7f2eeb2651eba","ref":"refs/heads/5.6","pushedAt":"2024-02-17T03:40:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Doc: update manpages for 5.6.0","shortMessageHtmlLink":"Doc: update manpages for 5.6.0"}},{"before":"badb446e0b5c8ade5b26d4c944f96cb64afed44e","after":"9a60dd86d7d17f4aa922c69831950a3a997cb2a1","ref":"refs/heads/master","pushedAt":"2024-02-17T00:23:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fuzzbawls","name":null,"path":"/Fuzzbawls","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7393257?s=80&v=4"},"commit":{"message":"Merge #2900: [Core] Bump Protocol Version to 70927\n\n9b7b24620b7ebaf31a40e6b4d81f8a4e80b19f13 Update Protocol Version 70927 (Liquid)\n\nPull request description:\n\n  As we integrate new Exchange Addresses into our system, its crucial to ensure compatibility and prevent potential conflicts arising from the new address prefix. So we are updating the protocol version to eliminate any compatibility issues or potentials to fork.\n\nACKs for top commit: 9b7b24620b7ebaf31a40e6b4d81f8a4e80b19f13\n  Fuzzbawls:\n    ACK 9b7b24620b7ebaf31a40e6b4d81f8a4e80b19f13\n  Duddino:\n    tACK 9b7b24620b7ebaf31a40e6b4d81f8a4e80b19f13\n\nTree-SHA512: 960caecb5b49874f797df91b2686a3af8db655c0e4aa88964ecef64a451a5878b005ad8cd4ae33a6092961cd531a0355942367ea235a47ef5e7dddc1b5c86015","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2127129261\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PIVX-Project/PIVX/issues/2900\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PIVX-Project/PIVX/pull/2900/hovercard\" href=\"https://github.com/PIVX-Project/PIVX/pull/2900\">#2900</a>: [Core] Bump Protocol Version to 70927"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yMFQwNDowNDoxMi4wMDAwMDBazwAAAASeqUYL","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMi0xN1QwMDoyMzowMS4wMDAwMDBazwAAAAP9EIAJ"}},"title":"Activity · PIVX-Project/PIVX"}